all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager] fix #6379: apply vzdump.conf compress default to GUI.
Date: Mon, 29 Sep 2025 16:35:52 +0200	[thread overview]
Message-ID: <20250929143552.191504-1-n.frey@proxmox.com> (raw)

Ensure the GUI uses the default 'compress' value in /etc/vzdump.conf
for manual backups and Backup Jobs, matching vzdump CLI behavior.

Backup Jobs continue to use the cluster-wide default of 'zstd'.
When a single node is selected, the job now uses that node's default
'compress' value from /etc/vzdump.conf.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6379

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 www/manager6/dc/Backup.js     | 21 +++++++++++++++++++++
 www/manager6/window/Backup.js |  3 +++
 2 files changed, 24 insertions(+)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 956a7cdf..7cca08ca 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -76,6 +76,27 @@ Ext.define('PVE.dc.BackupEdit', {
             if (mode === 'pool') {
                 me.selectPoolMembers();
             }
+
+            let compressionSelector = me.lookup('compressionSelector');
+            if (value !== undefined && value !== '' && value !== null) {
+                Proxmox.Utils.API2Request({
+                    url: `/nodes/${value}/vzdump/defaults`,
+                    method: 'GET',
+                    success: function (response, _) {
+                        const data = response.result.data;
+
+                        if (data.compress !== undefined) {
+                            compressionSelector.setValue(data.compress);
+                        }
+                    },
+                    failure: function (response, _) {
+                        Ext.Msg.alert(gettext('Error'), response.htmlStatus);
+                    },
+                });
+            } else {
+                // default value for cluster-wide backup
+                compressionSelector.setValue('zstd');
+            }
         },
 
         storageChange: function (f, v) {
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 65ec9659..cf6d4e4c 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -193,6 +193,9 @@ Ext.define('PVE.window.Backup', {
                                     PVE.Utils.unEscapeNotesTemplate(data['notes-template']),
                                 );
                             }
+                            if (!initialDefaults && data.compress !== undefined) {
+                                compressionSelector.setValue(data.compress);
+                            }
 
                             initialDefaults = true;
 
-- 
2.47.3


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


                 reply	other threads:[~2025-09-29 14:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250929143552.191504-1-n.frey@proxmox.com \
    --to=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal