all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v2 4/6] config: schema: define default OS type
Date: Mon, 29 Sep 2025 14:56:49 +0200	[thread overview]
Message-ID: <20250929125852.102343-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250929125852.102343-1-f.ebner@proxmox.com>

Like this, the Cfg2Cmd module can fill in the default and only needs
to check for definedness once.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index cb7755b6..af4b2ea7 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -376,6 +376,7 @@ my $confdesc = {
         type => 'string',
         # NOTE: When extending, also consider extending `%guest_types` in `Import/ESXi.pm`.
         enum => [qw(other wxp w2k w2k3 w2k8 wvista win7 win8 win10 win11 l24 l26 solaris)],
+        default => 'other',
         description => "Specify guest operating system.",
         verbose_description => <<EODESC,
 Specify guest operating system. This is used to enable special
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-09-29 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29 12:56 [pve-devel] [PATCH-SERIES qemu-server v2 0/6] cfg2cmd: introduce dedicated module and turn off hpet timer Fiona Ebner
2025-09-29 12:56 ` [pve-devel] [PATCH qemu-server v2 1/6] tests: cfg2cmd: add tests for startdate parameter and disabled time drift fix Fiona Ebner
2025-09-29 12:56 ` [pve-devel] [PATCH qemu-server v2 2/6] tests: add tests for non-{Linux, Windows} OS types Fiona Ebner
2025-09-29 12:56 ` [pve-devel] [PATCH qemu-server v2 3/6] introduce dedicated cfg2cmd module Fiona Ebner
2025-09-29 12:56 ` Fiona Ebner [this message]
2025-09-29 12:56 ` [pve-devel] [PATCH qemu-server v2 5/6] cfg2cmd: turn off hpet for Linux VMs running at least kernel 2.6 and machine type >= 10.1 Fiona Ebner
2025-09-29 12:56 ` [pve-devel] [PATCH qemu-server v2 6/6] tests: cfg2cmd: regenerate with QEMU 10.1 binary Fiona Ebner
2025-10-03 20:29 ` [pve-devel] applied: [PATCH-SERIES qemu-server v2 0/6] cfg2cmd: introduce dedicated module and turn off hpet timer Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250929125852.102343-5-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal