From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v2 qemu-server 0/2] fix #6207: vm status fixes
Date: Thu, 25 Sep 2025 14:25:07 +0200 [thread overview]
Message-ID: <20250925122829.70121-1-f.ebner@proxmox.com> (raw)
Changes in v2 (many thanks to Thomas for the discussion!):
* New approach, return undef instead of caching previous value.
* Add new patch to improve how 'query-proxmox-support' QMP commands
are issued.
If disk read/write cannot be queried because of QMP timeout, they
should not be reported as 0, because a consumer of the RRD stats
cannot distinguish between 0 being an actual 0 value and 0 being an
indicator for the absence of the real value. The RRD graphs in the UI
will already show this correctly.
Additionally, the 'query-proxmox-support' command was not yet part of
the QMP queue, but done sequentially with a timeout of 5 seconds each,
which is not acceptable for pvestatd. The second patch fixes that.
Fiona Ebner (2):
fix #6207: vm status: return undef values when disk{read,write} cannot
be queried
vm status: also queue query-proxmox-support QMP commands
src/PVE/QemuServer.pm | 20 ++++++++------------
1 file changed, 8 insertions(+), 12 deletions(-)
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-09-25 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 12:25 Fiona Ebner [this message]
2025-09-25 12:25 ` [pve-devel] [PATCH v2 qemu-server 1/2] fix #6207: vm status: return undef values when disk{read, write} cannot be queried Fiona Ebner
2025-09-25 12:25 ` [pve-devel] [PATCH qemu-server 2/2] vm status: also queue query-proxmox-support QMP commands Fiona Ebner
2025-09-25 14:13 ` [pve-devel] applied: [PATCH-SERIES v2 qemu-server 0/2] fix #6207: vm status fixes Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925122829.70121-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.