From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api master v2] config: silence ENOENT when comparing SMTP filter config
Date: Tue, 23 Sep 2025 13:09:54 +0200 [thread overview]
Message-ID: <20250923111000.96989-1-m.carrara@proxmox.com> (raw)
If `/run/pmg-smtp-filter.cfg` doesn't yet exist when `pmgsync.service`
runs, a "No such file or directory" warning is logged. While this has
been around since a while [0], the warning might look suspicious to
some (as it did to me during testing).
Therefore, silence the warning if there's an ENOENT.
[0]: https://git.proxmox.com/?p=pmg-api.git;a=commitdiff;h=e5b31a6178118981e784b225941f1502ba644ee5
Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
src/PMG/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm
index 44e5463..20168ac 100644
--- a/src/PMG/Config.pm
+++ b/src/PMG/Config.pm
@@ -1910,7 +1910,7 @@ sub compare_smtp_filter_config {
eval { $old = PVE::Tools::file_get_contents($smtp_filter_cfg); };
if (my $err = $@) {
- syslog('warning', "reloading pmg-smtp-filter: $err");
+ syslog('warning', "reloading pmg-smtp-filter: $err") if !$!{ENOENT};
$ret = 1;
} else {
my $new = $self->dump_smtp_filter_config();
--
2.47.3
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next reply other threads:[~2025-09-23 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 11:09 Max R. Carrara [this message]
2025-09-23 19:13 ` [pmg-devel] applied: " Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923111000.96989-1-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.