[pdm-devel] [PATCH yew-comp 3/8] meter label: make value optional

From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp 3/8] meter label: make value optional
Date: Tue, 23 Sep 2025 11:51:06 +0200	[thread overview]
Message-ID: <20250923095124.1679038-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250923095124.1679038-1-d.csapak@proxmox.com>

If there is no value given, just omit the Meter, so it's behaving like a
`StatusRow`. This can come in handy in situations where we use both
`StatusRow` and `MeterLabel` but want to abstract the specific
configuration away.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/meter_label.rs | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/meter_label.rs b/src/meter_label.rs
index 5b9e843..c4ef22f 100644
--- a/src/meter_label.rs
+++ b/src/meter_label.rs
@@ -56,9 +56,9 @@ pub struct MeterLabel {
     /// specified, but not within the range given by the min attribute
     /// and max attribute, the value is equal to the nearest end of
     /// the range.
-    #[prop_or(0f32)]
-    #[builder]
-    pub value: f32,
+    #[prop_or_default]
+    #[builder(IntoPropValue, into_prop_value)]
+    pub value: Option<f32>,
 
     #[prop_or_default]
     pub status: Option<Html>,
@@ -116,7 +116,10 @@ impl Component for ProxmoxMeterLabel {
 
         let status = match &props.status {
             Some(text) => text.clone(),
-            None => html! {format!("{:.2} %", props.value * 100.0)},
+            None => match props.value {
+                Some(value) => html! {format!("{:.2} %", value * 100.0)},
+                None => html! {},
+            },
         };
 
         let text_row = Row::new()
@@ -131,16 +134,16 @@ impl Component for ProxmoxMeterLabel {
             .with_std_props(&props.std_props)
             .listeners(&props.listeners)
             .with_child(text_row)
-            .with_child(
+            .with_optional_child(props.value.map(|value| {
                 Meter::new()
                     .margin_top(1)
-                    .value(props.value)
+                    .value(value)
                     .min(props.min)
                     .max(props.max)
                     .low(props.low)
                     .high(props.high)
-                    .optimum(props.optimum),
-            )
+                    .optimum(props.optimum)
+            }))
             .into()
     }
 }
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

