From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] partially-applied: [PATCH-SERIES pmg-api 0/3] fix #2077: remove dependency on Term::ReadLine
Date: Mon, 22 Sep 2025 21:11:40 +0200 [thread overview]
Message-ID: <20250922211140.35d69b25@rosa.proxmox.com> (raw)
In-Reply-To: <20250918142052.131956-1-f.ebner@proxmox.com>
Thomas applied the pve-common patch - so I went ahead and applied
1/2: e214e9bf ("partially fix #2077: pmgconfig: remove dependency on
Term::ReadLine")
and
2/2: 3f2ccb1f ("partially fix #2077: pmgcm: remove dependency on
Term::ReadLine")
Thanks again for the patches!
On Thu, 18 Sep 2025 16:19:40 +0200
Fiona Ebner <f.ebner@proxmox.com> wrote:
> As a side-effect, this also fixes #6748.
>
> Term::ReadLine would prompt and read from terminal even if
> stdin/stdout are redirected, the new helper will use the redirected
> channels. It also would underline the prompt, which the new helper
> does not. And Term::ReadLine also has advanced editing and history
> shortcuts.
>
> For the prompts in pmgconfig and pmgcm, not having the advanced
> features is perfectly fine. For pmgsh, which additionally configures
> even more features of than mentioned above, the change is rather bad.
>
> Depends on the following pve-common patch:
> https://lore.proxmox.com/pve-devel/20250918135215.95188-2-f.ebner@proxmox.com/
> Dependency bump for pve-common needed.
>
>
> Fiona Ebner (4):
> partially fix #2077: pmgconfig: remove dependency on Term::ReadLine
> partially fix #2077: pmgcm: remove dependency on Term::ReadLine
> partially fix #2077: pmgsh: remove dependency on Term::ReadLine
> d/control: remove libterm-readline-gnu-perl dependency
>
> debian/control | 1 -
> src/PMG/CLI/pmgcm.pm | 7 ++-----
> src/PMG/CLI/pmgconfig.pm | 19 +++++++------------
> src/bin/pmgsh | 35 ++---------------------------------
> 4 files changed, 11 insertions(+), 51 deletions(-)
>
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-09-22 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 14:19 [pmg-devel] " Fiona Ebner
2025-09-18 14:19 ` [pmg-devel] [PATCH pmg-api 1/4] partially fix #2077: pmgconfig: " Fiona Ebner
2025-09-22 9:47 ` Stoiko Ivanov
2025-09-18 14:19 ` [pmg-devel] [PATCH pmg-api 2/4] partially fix #2077: pmgcm: " Fiona Ebner
2025-09-22 9:46 ` Stoiko Ivanov
2025-09-18 14:19 ` [pmg-devel] [PATCH pmg-api 3/4] partially fix #2077: pmgsh: " Fiona Ebner
2025-09-18 20:58 ` Stoiko Ivanov
2025-09-19 8:41 ` Fiona Ebner
2025-09-22 9:47 ` Stoiko Ivanov
2025-09-18 14:19 ` [pmg-devel] [RFC pmg-api 4/4] d/control: remove libterm-readline-gnu-perl dependency Fiona Ebner
2025-09-22 19:11 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922211140.35d69b25@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.