From: Thomas Skinner <thomas@atskinner.net>
To: pve-devel@lists.proxmox.com
Cc: Thomas Skinner <thomas@atskinner.net>
Subject: [pve-devel] [PATCH manager v2 2/2] add UI for node maintenance enable/disable
Date: Sat, 20 Sep 2025 13:20:50 -0500 [thread overview]
Message-ID: <20250920182050.1657928-5-thomas@atskinner.net> (raw)
In-Reply-To: <20250920182050.1657928-1-thomas@atskinner.net>
Signed-off-by: Thomas Skinner <thomas@atskinner.net>
---
www/manager6/ha/StatusView.js | 92 +++++++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js
index 50ad8e84..4163f637 100644
--- a/www/manager6/ha/StatusView.js
+++ b/www/manager6/ha/StatusView.js
@@ -41,12 +41,75 @@ Ext.define(
},
});
+ let sm = Ext.create('Ext.selection.RowModel', {});
+
+ let caps = Ext.state.Manager.get('GuiCap');
+
+ let setNodeMaintenance = function (setEnabled) {
+ let rec = sm.getSelection()[0];
+ if (!rec || rec.data.type !== 'lrm') {
+ return;
+ }
+ let nodeName = rec.get('node');
+ let enableText = setEnabled ? 'Enable' : 'Disable';
+ let msg = Ext.String.format(
+ gettext("{0} maintenance mode on node '{1}'?"),
+ enableText,
+ nodeName,
+ );
+ Ext.Msg.confirm(gettext('Confirm'), msg, (btn) => {
+ if (btn === 'yes') {
+ Proxmox.Utils.API2Request({
+ params: { 'maintenance-mode': setEnabled ? 'enable' : 'disable' },
+ url: '/nodes/' + nodeName + '/maintenance',
+ method: 'PUT',
+ waitMsgTarget: me,
+ failure: function (response, opts) {
+ Ext.Msg.alert(gettext('Error'), response.htmlStatus);
+ },
+ });
+ }
+ });
+ };
+
+ let setMaintenanceButtonStates = function (isLRM, isMaintenance) {
+ me.down('#nodeMaintenanceMenu').setDisabled(!(caps.nodes['Sys.Console'] && isLRM));
+ me.down('#nodeMaintenanceEnableBtn').setDisabled(isMaintenance);
+ me.down('#nodeMaintenanceDisableBtn').setDisabled(!isMaintenance);
+ };
+
Ext.apply(me, {
store: store,
+ selModel: sm,
stateful: false,
viewConfig: {
trackOver: false,
},
+ tbar: [
+ {
+ text: gettext('Maintenance Mode'),
+ itemId: 'nodeMaintenanceMenu',
+ disabled: true,
+ menu: new Ext.menu.Menu({
+ items: [
+ {
+ text: gettext('Enable'),
+ itemId: 'nodeMaintenanceEnableBtn',
+ iconCls: 'fa fa-wrench',
+ disabled: true,
+ handler: () => setNodeMaintenance(true),
+ },
+ {
+ text: gettext('Disable'),
+ itemId: 'nodeMaintenanceDisableBtn',
+ iconCls: 'fa fa-check',
+ disabled: true,
+ handler: () => setNodeMaintenance(false),
+ },
+ ],
+ }),
+ },
+ ],
columns: [
{
header: gettext('Type'),
@@ -60,12 +123,40 @@ Ext.define(
dataIndex: 'status',
},
],
+ listeners: {
+ beforeselect: function (tree, record, index, eopts) {
+ if (record) {
+ let isLRM = record.data.type === 'lrm';
+ let isMaintenance = record.data.lrm_mode === 'maintenance';
+ setMaintenanceButtonStates(isLRM, isMaintenance);
+ }
+ },
+ },
});
me.callParent();
me.on('activate', me.rstore.startUpdate);
me.on('destroy', me.rstore.stopUpdate);
+
+ me.mon(me.rstore, 'load', function (curstore, results) {
+ let rec = sm.getSelection()[0];
+ if (!rec || rec.data.type !== 'lrm') {
+ return;
+ }
+ for (const { data } of results) {
+ switch (data.type) {
+ case 'lrm':
+ if (rec.data.node === data.node) {
+ let isMaintenance = rec.data.lrm_mode === 'maintenance';
+ setMaintenanceButtonStates(true, isMaintenance);
+ }
+ break;
+ default:
+ break;
+ }
+ }
+ });
},
},
function () {
@@ -88,6 +179,7 @@ Ext.define(
'type',
'crm_state',
'request_state',
+ 'lrm_mode',
{
name: 'vname',
convert: function (value, record) {
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-20 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 18:20 [pve-devel] [PATCH SERIES docs/ha-manager/manager v2] close #6144: add ui button + api for node maintenance mode Thomas Skinner
2025-09-20 18:20 ` [pve-devel] [PATCH ha-manager v2 1/1] add additional api field for lrm_mode in status check Thomas Skinner
2025-09-20 18:20 ` [pve-devel] [PATCH manager v2 1/2] add api setter for node maintenance mode Thomas Skinner
2025-09-20 18:20 ` [pve-devel] [PATCH docs v2 1/1] add docs for maintenance mode buttons in UI Thomas Skinner
2025-09-20 18:20 ` Thomas Skinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250920182050.1657928-5-thomas@atskinner.net \
--to=thomas@atskinner.net \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.