all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES qemu-server 0/6] VM-state property handling improvements
Date: Wed, 17 Sep 2025 18:30:24 +0200	[thread overview]
Message-ID: <20250917163038.488710-1-f.ebner@proxmox.com> (raw)

Fix bug #6805, fix handling nets-host-mtu in more contexts like resume
from hibernation and printing the commandline of a snapshot. Disallow
setting that property by a user via API like is done for other
VM-state properties.

Sorry, I thought I had checked for all occurences of 'runningmachine'
when introducing 'running-nets-host-mtu', but apparently I missed some
in the QemuServer module :(

Also introduce proper privilege checking for VM-state properties.

Finally, detect and cleanup such properties upon VM start.

I haven't come around to testing these for stable-bookworm yet, but
will let you know if they apply/work cleanly there too.


Fiona Ebner (6):
  partially fix #6805: api: clone: properly remove all snapshot-related
    info
  partially fix #6805: api: modify vm config: privilege checks for
    VM-state-related properties
  api: create/update: disallow setting 'running-nets-host-mtu' via API
  resume from suspended: properly handle 'nets-host-mtu'
  vm commandline: handle 'nets-host-mtu' property in snapshot
  vm start: remove left-over VM-state-related properties

 src/PVE/API2/Qemu.pm  |  9 +++++++--
 src/PVE/QemuServer.pm | 24 ++++++++++++++++++++++--
 2 files changed, 29 insertions(+), 4 deletions(-)

-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-09-17 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 16:30 Fiona Ebner [this message]
2025-09-17 16:30 ` [pve-devel] [PATCH qemu-server 1/6] partially fix #6805: api: clone: properly remove all snapshot-related info Fiona Ebner
2025-09-17 16:30 ` [pve-devel] [PATCH qemu-server 2/6] partially fix #6805: api: modify vm config: privilege checks for VM-state-related properties Fiona Ebner
2025-09-17 16:30 ` [pve-devel] [PATCH qemu-server 3/6] api: create/update: disallow setting 'running-nets-host-mtu' via API Fiona Ebner
2025-09-17 16:30 ` [pve-devel] [PATCH qemu-server 4/6] resume from suspended: properly handle 'nets-host-mtu' Fiona Ebner
2025-09-17 16:30 ` [pve-devel] [PATCH qemu-server 5/6] vm commandline: handle 'nets-host-mtu' property in snapshot Fiona Ebner
2025-09-17 16:30 ` [pve-devel] [PATCH qemu-server 6/6] vm start: remove left-over VM-state-related properties Fiona Ebner
2025-09-17 16:52 ` [pve-devel] applied: [PATCH-SERIES qemu-server 0/6] VM-state property handling improvements Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917163038.488710-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal