From: Shan Shaji <s.shaji@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Shan Shaji <s.shaji@proxmox.com>
Subject: [pbs-devel] [PATCH proxmox-backup] fix #6398: api: allow non-pam users to access shell
Date: Mon, 15 Sep 2025 14:57:53 +0200 [thread overview]
Message-ID: <20250915125753.281895-1-s.shaji@proxmox.com> (raw)
Right now PBS is not allowing users to access the shell if the user
is not a pam user even though the `Sys.Console` permission is
already given. To fix the issue removed the palm realm check.
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
src/api2/node/mod.rs | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/api2/node/mod.rs b/src/api2/node/mod.rs
index e7c6213c..34d4fb77 100644
--- a/src/api2/node/mod.rs
+++ b/src/api2/node/mod.rs
@@ -92,7 +92,7 @@ pub const SHELL_CMD_SCHEMA: Schema = StringSchema::new("The command to run.")
}
},
access: {
- description: "Restricted to users on realm 'pam'",
+ description: "The user needs Sys.Console on /system.",
permission: &Permission::Privilege(&["system"], PRIV_SYS_CONSOLE, false),
}
)]
@@ -110,10 +110,6 @@ async fn termproxy(cmd: Option<String>, rpcenv: &mut dyn RpcEnvironment) -> Resu
let userid = auth_id.user();
- if userid.realm() != "pam" {
- bail!("only pam users can use the console");
- }
-
let path = "/system";
// use port 0 and let the kernel decide which port is free
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
reply other threads:[~2025-09-15 12:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915125753.281895-1-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.