From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH network] frr: print task warning when frr reload fails
Date: Thu, 11 Sep 2025 17:33:54 +0200 [thread overview]
Message-ID: <20250911153359.278834-1-g.goller@proxmox.com> (raw)
Instead of just printing a normal warning, use log_warn, which adds a
warning to the whole task. This means the whole task ends with a
"warning" status which is visible nicely in the task list. Previously we
just printed a warning, which made the task end with "OK" even if the
reload failed.
frr-reload.py only fails if it's not installed (where a warning status
is ok) or the configuration is not valid (where a warning status is also
ok). Having frr-reload.py uninstalled for some reason and always relying
on `systemctl restart frr` to reload the sdn config is kinda weird and
you probably deserve to get a warning on each sdn apply task.
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
src/PVE/Network/SDN/Frr.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm
index b548e7b4f0fe..b607b32c248d 100644
--- a/src/PVE/Network/SDN/Frr.pm
+++ b/src/PVE/Network/SDN/Frr.pm
@@ -70,7 +70,7 @@ sub apply {
eval { reload() };
return if !$@;
- warn "reloading frr configuration failed: $@";
+ log_warn("reloading frr configuration failed: $@");
warn "trying to restart frr instead";
}
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-09-11 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 15:33 Gabriel Goller [this message]
2025-09-11 15:52 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911153359.278834-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.