all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com, yew-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-widget-toolkit-assets] dropdown: limit height of picker
Date: Thu, 11 Sep 2025 08:45:24 +0200	[thread overview]
Message-ID: <20250911064548.245619-1-d.csapak@proxmox.com> (raw)

so that it does not grow to (nearly) the full screen height.

Better solution is to add some option to the aligning code that limits
the height so that the field of the dropdown is always visible, but for
now this is an ok stopgap.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
note we have to update the submodule in pdm for this to take effect

 scss/_dropdown.scss | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scss/_dropdown.scss b/scss/_dropdown.scss
index 671b872..ab640c0 100644
--- a/scss/_dropdown.scss
+++ b/scss/_dropdown.scss
@@ -6,7 +6,9 @@
 
     @include elevation-box-shadow(1);
 
-    max-height: 100dvh;
+    // limit the height of the dropdown so it does not fill the whole screen.
+    // FIXME: add an aligning option to limit the height so the field is always viisble
+    max-height: min(50dvh, 400px) ! important;
     max-width: 100dvw;
     /* make e.g. the header menu overflow visible */
     overflow: visible;
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


WARNING: multiple messages have this Message-ID
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com, yew-devel@lists.proxmox.com
Subject: [yew-devel] [PATCH yew-widget-toolkit-assets] dropdown: limit height of picker
Date: Thu, 11 Sep 2025 08:45:24 +0200	[thread overview]
Message-ID: <20250911064548.245619-1-d.csapak@proxmox.com> (raw)

so that it does not grow to (nearly) the full screen height.

Better solution is to add some option to the aligning code that limits
the height so that the field of the dropdown is always visible, but for
now this is an ok stopgap.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
note we have to update the submodule in pdm for this to take effect

 scss/_dropdown.scss | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scss/_dropdown.scss b/scss/_dropdown.scss
index 671b872..ab640c0 100644
--- a/scss/_dropdown.scss
+++ b/scss/_dropdown.scss
@@ -6,7 +6,9 @@
 
     @include elevation-box-shadow(1);
 
-    max-height: 100dvh;
+    // limit the height of the dropdown so it does not fill the whole screen.
+    // FIXME: add an aligning option to limit the height so the field is always viisble
+    max-height: min(50dvh, 400px) ! important;
     max-width: 100dvw;
     /* make e.g. the header menu overflow visible */
     overflow: visible;
-- 
2.47.3



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel


             reply	other threads:[~2025-09-11  6:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11  6:45 Dominik Csapak [this message]
2025-09-11  6:45 ` [yew-devel] " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250911064548.245619-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal