all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] parser: qemu cpu: also allow kebab-cased properties while parsing
@ 2025-09-05 14:22 Daniel Kral
  2025-09-05 17:40 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Kral @ 2025-09-05 14:22 UTC (permalink / raw)
  To: pve-devel

There are quite a few kebab-cased properties in the QEMU CPU config,
such as phys-bits and guest-phys-bits. These are currently not exposed
through the web interface, but only the command line.

If the QEMU CPU config is parsed, it will return undefined with an
error and will break the ProcessorEdit component so that changes cannot
be submitted anymore.

Fix that by allowing kebab-cased properties as well.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 www/manager6/Parser.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js
index 4e0f530b..9b68434d 100644
--- a/www/manager6/Parser.js
+++ b/www/manager6/Parser.js
@@ -533,7 +533,7 @@ Ext.define('PVE.Parser', {
                     return undefined; // continue
                 }
 
-                let match = p.match(/^([a-z_]+)=(\S+)$/);
+                let match = p.match(/^([a-z_\-]+)=(\S+)$/);
                 if (!match || Ext.isDefined(res[match[1]])) {
                     errors = true;
                     return false; // break
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] parser: qemu cpu: also allow kebab-cased properties while parsing
  2025-09-05 14:22 [pve-devel] [PATCH manager] parser: qemu cpu: also allow kebab-cased properties while parsing Daniel Kral
@ 2025-09-05 17:40 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-09-05 17:40 UTC (permalink / raw)
  To: pve-devel, Daniel Kral

On Fri, 05 Sep 2025 16:22:21 +0200, Daniel Kral wrote:
> There are quite a few kebab-cased properties in the QEMU CPU config,
> such as phys-bits and guest-phys-bits. These are currently not exposed
> through the web interface, but only the command line.
> 
> If the QEMU CPU config is parsed, it will return undefined with an
> error and will break the ProcessorEdit component so that changes cannot
> be submitted anymore.
> 
> [...]

Applied with squashing in a fixup to make the biome linter happy again, as
escaping the - as written was not required, while this is just a warning when
installing directly, we turn warnings into errors when building an actual
debian package, thanks!

[1/1] parser: qemu cpu: also allow kebab-cased properties while parsing
      commit: 2ddc4d864b59ed93b43b7bf2581b3eac32e8bfac


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-05 17:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-05 14:22 [pve-devel] [PATCH manager] parser: qemu cpu: also allow kebab-cased properties while parsing Daniel Kral
2025-09-05 17:40 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal