all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 0/4] gui/api performance improvements
Date: Fri,  5 Sep 2025 13:51:58 +0200	[thread overview]
Message-ID: <20250905120627.2585826-1-d.csapak@proxmox.com> (raw)

this series fixes a series of bad patterns in our api/gui code,
especially some O(n^2) code regarding resource count (vms/storages/etc.)

note that the api change is only a current stop-gap workaround and aaron
is working on making that code not necessary at all, but for now this
should be good.

The overall perforamnce improvement i see on my local test cluster with
~10000 vms is from

API ~22s + GUI ~8.5s

to

API 500ms + GUI 500ms

which is a ~30x speedup (since it's mostly quadratic code that is
removed, this is more noticable the more resources there are ofc)

Dominik Csapak (4):
  API2Tools: rrd: remove O(n^2) lookup for keys
  ui: fix O(n^2) calculations when loading /cluster/resources
  ui: resource tree: improve performance on initial update
  ui: resource tree: fix change detection

 PVE/API2Tools.pm                   |  7 +++----
 www/manager6/Utils.js              | 12 ++++--------
 www/manager6/data/ResourceStore.js | 20 ++++++++++++++++++++
 www/manager6/tree/ResourceTree.js  | 25 +++++++++++++++++++++++--
 4 files changed, 50 insertions(+), 14 deletions(-)

-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-09-05 12:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 11:51 Dominik Csapak [this message]
2025-09-05 11:51 ` [pve-devel] [PATCH manager 1/4] API2Tools: rrd: remove O(n^2) lookup for keys Dominik Csapak
2025-09-05 13:49   ` Aaron Lauterer
2025-09-05 13:53     ` Dominik Csapak
2025-09-05 13:58       ` Aaron Lauterer
2025-09-05 13:57   ` Daniel Kral
2025-09-05 11:52 ` [pve-devel] [PATCH manager 2/4] ui: fix O(n^2) calculations when loading /cluster/resources Dominik Csapak
2025-09-05 11:52 ` [pve-devel] [PATCH manager 3/4] ui: resource tree: improve performance on initial update Dominik Csapak
2025-09-05 11:52 ` [pve-devel] [PATCH manager 4/4] ui: resource tree: fix change detection Dominik Csapak
2025-09-05 17:40 ` [pve-devel] applied: [PATCH manager 0/4] gui/api performance improvements Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250905120627.2585826-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal