From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-backup v3 1/1] api: change integer schema parameters to i64
Date: Tue, 2 Sep 2025 16:09:27 +0200 [thread overview]
Message-ID: <20250902140956.228031-4-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250902140956.228031-1-s.hanreich@proxmox.com>
The type for the minimum / maximum / default values for integer
schemas has changed to i64 (from isize). Fix all call sites that are
converting to isize to convert to i64 instead.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
pbs-tape/src/bin/pmt.rs | 6 +++---
proxmox-backup-client/src/main.rs | 2 +-
pxar-bin/src/main.rs | 6 +++---
src/api2/backup/upload_chunk.rs | 15 ++++++---------
4 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/pbs-tape/src/bin/pmt.rs b/pbs-tape/src/bin/pmt.rs
index d70c61e9..77b61314 100644
--- a/pbs-tape/src/bin/pmt.rs
+++ b/pbs-tape/src/bin/pmt.rs
@@ -28,17 +28,17 @@ use pbs_tape::{
pub const FILE_MARK_COUNT_SCHEMA: Schema = IntegerSchema::new("File mark count.")
.minimum(1)
- .maximum(i32::MAX as isize)
+ .maximum(i32::MAX as i64)
.schema();
pub const FILE_MARK_POSITION_SCHEMA: Schema = IntegerSchema::new("File mark position (0 is BOT).")
.minimum(0)
- .maximum(i32::MAX as isize)
+ .maximum(i32::MAX as i64)
.schema();
pub const RECORD_COUNT_SCHEMA: Schema = IntegerSchema::new("Record count.")
.minimum(1)
- .maximum(i32::MAX as isize)
+ .maximum(i32::MAX as i64)
.schema();
pub const DRIVE_OPTION_SCHEMA: Schema =
diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
index 3f6c5adb..7dc2c486 100644
--- a/proxmox-backup-client/src/main.rs
+++ b/proxmox-backup-client/src/main.rs
@@ -726,7 +726,7 @@ fn spawn_catalog_upload(
type: Integer,
description: "Max number of entries to hold in memory.",
optional: true,
- default: pbs_client::pxar::ENCODER_MAX_ENTRIES as isize,
+ default: pbs_client::pxar::ENCODER_MAX_ENTRIES as i64,
},
"dry-run": {
type: Boolean,
diff --git a/pxar-bin/src/main.rs b/pxar-bin/src/main.rs
index cccbb331..cba5646b 100644
--- a/pxar-bin/src/main.rs
+++ b/pxar-bin/src/main.rs
@@ -330,9 +330,9 @@ fn extract_archive(
"entries-max": {
description: "Max number of entries loaded at once into memory",
optional: true,
- default: ENCODER_MAX_ENTRIES as isize,
+ default: ENCODER_MAX_ENTRIES as i64,
minimum: 0,
- maximum: isize::MAX,
+ maximum: i64::MAX,
},
"payload-output": {
description: "'ppxar' payload output data file to create split archive.",
@@ -354,7 +354,7 @@ async fn create_archive(
no_fifos: bool,
no_sockets: bool,
exclude: Option<Vec<String>>,
- entries_max: isize,
+ entries_max: i64,
payload_output: Option<String>,
) -> Result<(), Error> {
let patterns = {
diff --git a/src/api2/backup/upload_chunk.rs b/src/api2/backup/upload_chunk.rs
index f8b7ecbd..8dd7e4d5 100644
--- a/src/api2/backup/upload_chunk.rs
+++ b/src/api2/backup/upload_chunk.rs
@@ -134,10 +134,9 @@ pub const API_METHOD_UPLOAD_FIXED_CHUNK: ApiMethod = ApiMethod::new(
"encoded-size",
false,
&IntegerSchema::new("Encoded chunk size.")
- .minimum((std::mem::size_of::<DataBlobHeader>() as isize) + 1)
+ .minimum((std::mem::size_of::<DataBlobHeader>() as i64) + 1)
.maximum(
- 1024 * 1024 * 16
- + (std::mem::size_of::<EncryptedDataBlobHeader>() as isize)
+ 1024 * 1024 * 16 + (std::mem::size_of::<EncryptedDataBlobHeader>() as i64)
)
.schema()
),
@@ -197,10 +196,9 @@ pub const API_METHOD_UPLOAD_DYNAMIC_CHUNK: ApiMethod = ApiMethod::new(
"encoded-size",
false,
&IntegerSchema::new("Encoded chunk size.")
- .minimum((std::mem::size_of::<DataBlobHeader>() as isize) + 1)
+ .minimum((std::mem::size_of::<DataBlobHeader>() as i64) + 1)
.maximum(
- 1024 * 1024 * 16
- + (std::mem::size_of::<EncryptedDataBlobHeader>() as isize)
+ 1024 * 1024 * 16 + (std::mem::size_of::<EncryptedDataBlobHeader>() as i64)
)
.schema()
),
@@ -357,10 +355,9 @@ pub const API_METHOD_UPLOAD_BLOB: ApiMethod = ApiMethod::new(
"encoded-size",
false,
&IntegerSchema::new("Encoded blob size.")
- .minimum(std::mem::size_of::<DataBlobHeader>() as isize)
+ .minimum(std::mem::size_of::<DataBlobHeader>() as i64)
.maximum(
- 1024 * 1024 * 16
- + (std::mem::size_of::<EncryptedDataBlobHeader>() as isize)
+ 1024 * 1024 * 16 + (std::mem::size_of::<EncryptedDataBlobHeader>() as i64)
)
.schema()
)
--
2.47.2
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-02 14:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 14:09 [pdm-devel] [PATCH network/proxmox{, -backup, -api-types, -datacenter-manager} v3 00/30] Add initial SDN / EVPN integration Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox v3 1/2] schema: use i64 for minimum / maximum / default integer values Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox v3 2/2] pbs-api-types: fix values for integer schemas Stefan Hanreich
2025-09-02 14:09 ` Stefan Hanreich [this message]
2025-09-02 14:09 ` [pdm-devel] [PATCH pve-network v3 1/6] sdn: api: return null for rollback / lock endpoints Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH pve-network v3 2/6] controllers: fix maximum value for ASN Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH pve-network v3 3/6] api: add state standard option Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH pve-network v3 4/6] api: controllers: update schema of endpoints Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH pve-network v3 5/6] api: vnets: " Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH pve-network v3 6/6] api: zones: " Stefan Hanreich
2025-09-03 9:37 ` Shannon Sterz
2025-09-03 13:04 ` Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-api-types v3 1/6] sdn: add list/create zone endpoints Stefan Hanreich
2025-09-03 9:36 ` Shannon Sterz
2025-09-03 13:15 ` Wolfgang Bumiller
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-api-types v3 2/6] sdn: add list/create vnet endpoints Stefan Hanreich
2025-09-03 9:36 ` Shannon Sterz
2025-09-03 12:07 ` Stefan Hanreich
2025-09-03 13:16 ` Wolfgang Bumiller
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-api-types v3 3/6] sdn: add list/create controller endpoints Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-api-types v3 4/6] sdn: add sdn configuration locking endpoints Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-api-types v3 5/6] tasks: add helper for querying successfully finished tasks Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-api-types v3 6/6] sdn: add helpers for pending values Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 01/15] server: add locked sdn client helpers Stefan Hanreich
2025-09-03 9:37 ` Shannon Sterz
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 02/15] ui: pve: sdn: add descriptions for sdn tasks Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 03/15] api: sdn: add list_zones endpoint Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 04/15] api: sdn: add create_zone endpoint Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 05/15] api: sdn: add list_vnets endpoint Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 06/15] api: sdn: add create_vnet endpoint Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 07/15] api: sdn: add list_controllers endpoint Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 08/15] ui: sdn: add EvpnRouteTarget type Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 09/15] ui: sdn: add vnet icon Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 10/15] ui: sdn: add view for showing evpn zones Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 11/15] ui: sdn: add view for showing ip vrfs Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 12/15] ui: sdn: add component for creating evpn vnets Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 13/15] ui: sdn: add component for creatin evpn zones Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 14/15] ui: sdn: add evpn overview panel Stefan Hanreich
2025-09-02 14:09 ` [pdm-devel] [PATCH proxmox-datacenter-manager v3 15/15] ui: sdn: add evpn panel to main menu Stefan Hanreich
2025-09-02 14:13 ` [pdm-devel] [PATCH network/proxmox{, -backup, -api-types, -datacenter-manager} v3 00/30] Add initial SDN / EVPN integration Stefan Hanreich
2025-09-03 16:38 ` [pdm-devel] superseded: " Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902140956.228031-4-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.