From: Shannon Sterz <s.sterz@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp v3 1/3] api-types/role_selector: depend on common `RoleInfo` type
Date: Thu, 28 Aug 2025 12:59:08 +0200 [thread overview]
Message-ID: <20250828105912.294887-8-s.sterz@proxmox.com> (raw)
In-Reply-To: <20250828105912.294887-1-s.sterz@proxmox.com>
instead of redefining it here. this should make sure that we stay in
sync with the common api definition in `proxmox-access-control`.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
src/common_api_types.rs | 8 --------
src/role_selector.rs | 2 +-
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/common_api_types.rs b/src/common_api_types.rs
index 57415e9..03f7707 100644
--- a/src/common_api_types.rs
+++ b/src/common_api_types.rs
@@ -24,14 +24,6 @@ impl ExtractPrimaryKey for BasicRealmInfo {
}
}
-#[derive(Serialize, Deserialize, PartialEq, Clone)]
-pub struct RoleInfo {
- pub roleid: String,
- pub privs: Vec<String>,
- #[serde(skip_serializing_if = "Option::is_none")]
- pub comment: Option<String>,
-}
-
/// Upid covering different products (PVE, PBS and PDM)
///
/// Different products use different UPID formats. This type can parse
diff --git a/src/role_selector.rs b/src/role_selector.rs
index 7bde09f..20a8483 100644
--- a/src/role_selector.rs
+++ b/src/role_selector.rs
@@ -10,7 +10,7 @@ use pwt::widget::data_table::{DataTable, DataTableColumn, DataTableHeader};
use pwt::widget::form::{Selector, SelectorRenderArgs, ValidateFn};
use pwt::widget::GridPicker;
-use crate::common_api_types::RoleInfo;
+use proxmox_access_control::types::RoleInfo;
thread_local! {
static COLUMNS: Rc<Vec<DataTableHeader<RoleInfo>>> = Rc::new(vec![
--
2.47.2
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-08-28 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 10:59 [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp v3 00/11] ACL edit api and ui components Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH proxmox v3 1/6] access-control: add more types to prepare for api feature Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH proxmox v3 2/6] access-control: add acl " Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH proxmox v3 3/6] access-control: add comments to roles function of AccessControlConfig Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH proxmox v3 4/6] access-control: add generic roles endpoint to `api` feature Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH proxmox v3 5/6] access-control: api: refactor validation checks to re-use existing code Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH proxmox v3 6/6] access-control: api: refactor extract_acl_node_data to be non-recursive Shannon Sterz
2025-08-28 10:59 ` Shannon Sterz [this message]
2025-08-28 10:59 ` [pdm-devel] [PATCH yew-comp v3 2/3] acl: add a view and semi-generic `EditWindow` for acl entries Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH yew-comp v3 3/3] role_selector/acl_edit: make api endpoint and default role configurable Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH datacenter-manager v3 1/2] server: use proxmox-access-control api implementations Shannon Sterz
2025-08-28 10:59 ` [pdm-devel] [PATCH datacenter-manager v3 2/2] ui: configuration: add panel for viewing and editing acl entries Shannon Sterz
2025-08-28 21:15 ` [pdm-devel] applied-series: [PATCH datacenter-manager/proxmox/yew-comp v3 00/11] ACL edit api and ui components Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828105912.294887-8-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.