* [pve-devel] [PATCH manager] ui: pool: members: fix store reload on add/remove
@ 2025-08-27 10:14 Christoph Heiss
2025-09-02 12:32 ` [pve-devel] applied: " Fabian Grünbichler
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Heiss @ 2025-08-27 10:14 UTC (permalink / raw)
To: pve-devel
.load() must be called on the underlying UpdateStore, not on the
DiffStore.
Currently, this results in the members list being cleared after
adding/removing an entry, only being reloaded (correctly) during the
next automatic background update.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
www/manager6/grid/PoolMembers.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
index f025a1380..de5104434 100644
--- a/www/manager6/grid/PoolMembers.js
+++ b/www/manager6/grid/PoolMembers.js
@@ -188,8 +188,8 @@ Ext.define('PVE.grid.PoolMembers', {
(c) => c.dataIndex !== 'tags' && c.dataIndex !== 'lock',
);
- var reload = function () {
- store.load();
+ const reload = function () {
+ me.rstore.load();
};
var sm = Ext.create('Ext.selection.RowModel', {});
--
2.50.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: pool: members: fix store reload on add/remove
2025-08-27 10:14 [pve-devel] [PATCH manager] ui: pool: members: fix store reload on add/remove Christoph Heiss
@ 2025-09-02 12:32 ` Fabian Grünbichler
0 siblings, 0 replies; 2+ messages in thread
From: Fabian Grünbichler @ 2025-09-02 12:32 UTC (permalink / raw)
To: pve-devel, Christoph Heiss
On Wed, 27 Aug 2025 12:14:16 +0200, Christoph Heiss wrote:
> .load() must be called on the underlying UpdateStore, not on the
> DiffStore.
>
> Currently, this results in the members list being cleared after
> adding/removing an entry, only being reloaded (correctly) during the
> next automatic background update.
>
> [...]
Applied with bug reference folded in, thanks!
[1/1] ui: pool: members: fix store reload on add/remove
commit: b99d14855f18d956a8eb10fb2f6508e8371790da
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-02 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-27 10:14 [pve-devel] [PATCH manager] ui: pool: members: fix store reload on add/remove Christoph Heiss
2025-09-02 12:32 ` [pve-devel] applied: " Fabian Grünbichler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.