* [pve-devel] [PATCH pve-cluster v3] fix #6615: rrd: only return last entry if populated
@ 2025-08-27 9:04 Hannes Laimer
0 siblings, 0 replies; only message in thread
From: Hannes Laimer @ 2025-08-27 9:04 UTC (permalink / raw)
To: pve-devel
RRD fetch can include the latest bucket before metrics are flushed,
resulting in entries with only a timestamp.
This now only returns the last entry if it contains at least one value.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
v3, thanks @Dominik:
- only remove last entry if empty, not all empty ones
src/PVE/RRD.pm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm
index 8fe1927..5a23889 100644
--- a/src/PVE/RRD.pm
+++ b/src/PVE/RRD.pm
@@ -81,6 +81,12 @@ sub create_rrd_data {
push @$res, $entry;
}
+ # The newest bucket can still be empty right after a boundary.
+ if (@$res) {
+ # only contains 'time'
+ pop @$res if (scalar(keys %{$res->[-1]}) == 1);
+ }
+
return $res;
}
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-08-27 9:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-27 9:04 [pve-devel] [PATCH pve-cluster v3] fix #6615: rrd: only return last entry if populated Hannes Laimer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.