all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Skinner <thomas@atskinner.net>
To: pve-devel@lists.proxmox.com
Cc: Thomas Skinner <thomas@atskinner.net>
Subject: [pve-devel] [PATCH manager 2/2] add UI for node maintenance enable/disable
Date: Sun, 24 Aug 2025 23:11:28 -0500	[thread overview]
Message-ID: <20250825041128.132814-6-thomas@atskinner.net> (raw)
In-Reply-To: <20250825041128.132814-1-thomas@atskinner.net>

Signed-off-by: Thomas Skinner <thomas@atskinner.net>
---
 www/manager6/ha/StatusView.js | 85 +++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js
index 50ad8e84..79e12df5 100644
--- a/www/manager6/ha/StatusView.js
+++ b/www/manager6/ha/StatusView.js
@@ -41,12 +41,58 @@ Ext.define(
                 },
             });
 
+            let sm = Ext.create('Ext.selection.RowModel', {});
+
+            let caps = Ext.state.Manager.get('GuiCap');
+
+            var node_maintenance_disable = function (disable) {
+                let rec = sm.getSelection()[0];
+                if (!rec || rec.data.type !== "lrm") {
+                    return;
+                }
+                let nodename = rec.get('node');
+                let enableText = disable ? 'Disable' : 'Enable';
+                let msg = Ext.String.format(gettext("{0} maintenance mode on node '{1}'?"), enableText, nodename);
+                Ext.Msg.confirm(gettext('Confirm'), msg, (btn) => {
+                    if (btn === 'yes') {
+                        Proxmox.Utils.API2Request({
+                            params: { disable: disable ? 1 : 0 },
+                            url: '/cluster/ha/nodes/' + nodename + '/maintenance',
+                            method: 'POST',
+                            waitMsgTarget: me,
+                            failure: function (response, opts) {
+                                Ext.Msg.alert(gettext('Error'), response.htmlStatus);
+                            },
+                        });
+                    }
+                });
+            };
+
             Ext.apply(me, {
                 store: store,
+                selModel: sm,
                 stateful: false,
                 viewConfig: {
                     trackOver: false,
                 },
+                tbar: [
+                    {
+                        text: gettext('Enable Maintenance Mode'),
+                        itemId: 'enableMaintBtn',
+                        disabled: true,
+                        handler: function () {
+                            node_maintenance_disable(false);
+                        },
+                    },
+                    {
+                        text: gettext('Disable Maintenance Mode'),
+                        itemId: 'disableMaintBtn',
+                        disabled: true,
+                        handler: function () {
+                            node_maintenance_disable(true);
+                        },
+                    },
+                ],
                 columns: [
                     {
                         header: gettext('Type'),
@@ -60,12 +106,50 @@ Ext.define(
                         dataIndex: 'status',
                     },
                 ],
+                listeners: {
+                    beforeselect: function (tree, record, index, eopts) {
+                        if (!caps.nodes['Sys.Console']) {
+                            return;
+                        }
+                        let enableMaintBtnDisable = true;
+                        let disableMaintBtnDisable = true;
+                        if (record && record.data.type === "lrm") {
+                            if (record.data.lrm_mode && record.data.lrm_mode === 'maintenance') {
+                                disableMaintBtnDisable = false;
+                            } else {
+                                enableMaintBtnDisable = false;
+                            }
+                        }
+                        me.down('#enableMaintBtn').setDisabled(enableMaintBtnDisable);
+                        me.down('#disableMaintBtn').setDisabled(disableMaintBtnDisable);
+                    },
+                }
             });
 
             me.callParent();
 
             me.on('activate', me.rstore.startUpdate);
             me.on('destroy', me.rstore.stopUpdate);
+
+            me.mon(me.rstore, 'load', function (curstore, results) {
+                let rec = sm.getSelection()[0];
+                if (!rec || rec.data.type !== "lrm") {
+                    return;
+                }
+                for (const { data } of results) {
+                    switch (data.type) {
+                        case 'lrm':
+                            if (rec.data.node === data.node) {
+                                let inMaint = rec.data.lrm_mode === 'maintenance';
+                                me.down('#enableMaintBtn').setDisabled(inMaint);
+                                me.down('#disableMaintBtn').setDisabled(!inMaint);
+                            }
+                            break;
+                        default:
+                            break;
+                    }
+                }
+            });
         },
     },
     function () {
@@ -88,6 +172,7 @@ Ext.define(
                 'type',
                 'crm_state',
                 'request_state',
+                'lrm_mode',
                 {
                     name: 'vname',
                     convert: function (value, record) {
-- 
2.47.2


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-08-25  4:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25  4:11 [pve-devel] [PATCH SERIES docs/ha-manager/manager] close #6144: add ui button + api for node maintenance mode Thomas Skinner
2025-08-25  4:11 ` [pve-devel] [PATCH ha-manager 1/2] add additional api field for lrm_mode in status check Thomas Skinner
2025-08-25  4:11 ` [pve-devel] [PATCH manager 1/2] add api path map for node HA endpoints Thomas Skinner
2025-08-26  9:38   ` Daniel Kral
2025-08-26 10:26     ` Thomas Lamprecht
2025-08-26 11:34       ` Daniel Kral
2025-08-25  4:11 ` [pve-devel] [PATCH docs 1/1] add docs for maintenance mode buttons in UI Thomas Skinner
2025-08-26  9:44   ` Daniel Kral
2025-08-26 16:05     ` Thomas Skinner
2025-08-27  7:50       ` Daniel Kral
2025-08-25  4:11 ` [pve-devel] [PATCH ha-manager 2/2] add api getter/setter for node maintenance mode Thomas Skinner
2025-08-26  9:38   ` Daniel Kral
2025-08-26 16:00     ` Thomas Skinner
2025-08-27  7:31       ` Thomas Lamprecht
2025-08-27  8:25       ` Daniel Kral
2025-08-27  9:20         ` Thomas Lamprecht
2025-08-29 20:13         ` Thomas Skinner
2025-09-01  8:52           ` Daniel Kral
2025-08-29 20:17     ` Thomas Skinner
2025-08-25  4:11 ` Thomas Skinner [this message]
2025-08-26 10:00   ` [pve-devel] [PATCH manager 2/2] add UI for node maintenance enable/disable Daniel Kral
2025-08-26 17:34     ` Thomas Skinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250825041128.132814-6-thomas@atskinner.net \
    --to=thomas@atskinner.net \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal