[pdm-devel] [PATCH datacenter-manager v3 00/23] ] improve remote wizard

[Dominik Csapak <d.csapak@proxmox.com>]

# Summary

This series improves the remote wizard in various points:
* improved wording and texts
* moved seperate buttons on pages into the next button
* probing of entered nodes
* confirmation dialog for missing fingerprints
* better realm selector

## Probing on the server side

I tried to determine if we need a fingerprint for nodes inside the
API call, by probing each node. Since we currently only get the
nodenames and not FQDNs in the nodelist, this will currently not
result in a valid connection in most cases and return the fingerprint.

My plan would be to include FQDNs of the nodes on the PVE side API call,
so we can return here a list of nodename, ip and FQDNs, which the user
then can select from. (which of those I'd probe on first check is yet
to be determined)

## Fingerprint confirmation dialogs

Not sure if we want to be able to let the user confirm the fingerprint
so easily. On one hand it's very convenient, but maybe leads to users
simply clicking yes without understanding what's happening.

If it's deemed too dangerous, I'd rework the series without this.

# Future work

The next step for the wizard is to have some kind of quick copy&paste
info. After discussing off-list with Fabian a bit, I think it would be
best for this to contain the hostname (FQDN?) + fingerprint (if just a
self-signed certificate) + a list of nodes with their respective
nodename + FQDNs (maybe requires api change on PVE side to generate
this). The user would then still have to do most of the steps currently
necessary in the wizard, except the manual copy & pasting of
fingerprints and maybe entering of FQDNs.

changes from v2:
* split up the scanning in two api calls (tls-probe and scan)
  since that make more sense, especially how we use it in the ui anyway
* some comment changes and variable names
* added a commit that changes the reset logic on the connection window
  so we only reset the following panels when the form changes
* when confirming the certificate on the first page, the fingerprint
  will be entered into the form, so a back and forth will not ask again

changes from v1:
* rebase on current master


Dominik Csapak (23):
  server/ui: pve: change 'realm list' api call to GET
  api types: RemoteType: put default port info to the type
  server: connection: add probe_tls_connection helper
  server: add probe-tls endpoint
  server: pve api: extend 'scan' so it tls-probes the nodes
  pdm-client: add scan_remote and probe_tls methods
  ui: remotes: node url list: add placeholder and clear trigger
  ui: remotes: node url list: make column header clearer
  ui: remotes: node url list: handle changing default
  ui: pve wizard: rename 'realm' variable to 'info'
  ui: pve wizard: summary: add default text for fingerprint
  ui: pve wizard: nodes: improve info text
  ui: pve wizard: nodes: probe hosts to verify fingerprint settings
  ui: pve wizard: info: use pdm_client for scanning
  ui: pve wizard: info: detect hostname and fingerprint
  ui: pve wizard: info: remove manual scan button
  ui: widget: add pve realm selector
  ui: pve wizard: info: use pve realm selector
  ui: pve wizard: connect: factor out normalize_hostname
  ui: pve wizard: connect: move connection logic to next button
  ui: pve wizard: connect: reset later pages when form changes
  ui: pve wizard: connect: use scan api endpoint instead of realms
  ui: pve wizard: connect: add certificate confirmation dialog

 lib/pdm-api-types/Cargo.toml          |   1 +
 lib/pdm-api-types/src/lib.rs          |   2 +
 lib/pdm-api-types/src/remotes.rs      |  19 ++
 lib/pdm-client/src/lib.rs             |  45 ++++
 server/src/api/pve/mod.rs             |  70 ++++--
 server/src/connection.rs              |  91 +++++++-
 ui/Cargo.toml                         |   1 +
 ui/src/remotes/add_wizard.rs          |   8 +-
 ui/src/remotes/node_url_list.rs       |  33 ++-
 ui/src/remotes/wizard_page_connect.rs | 314 +++++++++++++++++---------
 ui/src/remotes/wizard_page_info.rs    | 121 +++++-----
 ui/src/remotes/wizard_page_nodes.rs   | 239 +++++++++++++++++++-
 ui/src/remotes/wizard_page_summary.rs |   5 +-
 ui/src/widget/mod.rs                  |   3 +
 ui/src/widget/pve_realm_selector.rs   | 123 ++++++++++
 15 files changed, 872 insertions(+), 203 deletions(-)
 create mode 100644 ui/src/widget/pve_realm_selector.rs

-- 
2.47.2



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel