From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v7 6/7] remote tasks: task cache: create `active` file in init
Date: Wed, 20 Aug 2025 14:43:28 +0200 [thread overview]
Message-ID: <20250820124329.220124-7-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250820124329.220124-1-l.wagner@proxmox.com>
This avoids a 'could not create task archive iterator' error before the
first round of task fetching.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
Notes:
New in v7
server/src/remote_tasks/task_cache.rs | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/server/src/remote_tasks/task_cache.rs b/server/src/remote_tasks/task_cache.rs
index 9e6a65cd..1afeaee4 100644
--- a/server/src/remote_tasks/task_cache.rs
+++ b/server/src/remote_tasks/task_cache.rs
@@ -214,11 +214,24 @@ impl ReadableTaskCache {
}
impl WritableTaskCache {
- /// Create initial task archives that can be backfilled with the
+ /// Create initial task archive files that can be backfilled with the
/// recent task history from a remote.
///
/// This function only has an effect if there are no archive files yet.
pub fn init(&self, now: i64) -> Result<(), Error> {
+ let active_filename = self.cache.base_path.join(ACTIVE_FILENAME);
+
+ if !active_filename.exists() {
+ let mut file = OpenOptions::new()
+ .create(true)
+ .write(true)
+ .open(&active_filename)?;
+
+ self.cache
+ .create_options
+ .apply_to(&mut file, &active_filename)?;
+ }
+
if self.cache.archive_files(&self.lock)?.is_empty() {
for i in 0..self.cache.max_files {
self.new_file(
--
2.47.2
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-08-20 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 12:43 [pdm-devel] [PATCH proxmox-datacenter-manager v7 0/7] remote task cache fetching task / better cache backend Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 1/7] remote tasks: implement improved cache for remote tasks Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 2/7] remote tasks: add background task for task polling, use new task cache Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 3/7] pdm-api-types: remote tasks: add new_from_str constructor for TaskStateType Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 4/7] fake remote: make the fake_remote feature compile again Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 5/7] fake remote: clippy fixes Lukas Wagner
2025-08-20 12:43 ` Lukas Wagner [this message]
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 7/7] remote tasks: log error in case of task panic, instead of cancelling all tasks Lukas Wagner
2025-08-21 9:20 ` [pdm-devel] applied: [PATCH proxmox-datacenter-manager v7 0/7] remote task cache fetching task / better cache backend Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820124329.220124-7-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.