From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v7 5/7] fake remote: clippy fixes
Date: Wed, 20 Aug 2025 14:43:27 +0200 [thread overview]
Message-ID: <20250820124329.220124-6-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250820124329.220124-1-l.wagner@proxmox.com>
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
---
Notes:
No changes in v6
No changes in v5
No changes in v4
Added in v3
server/src/test_support/fake_remote.rs | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/server/src/test_support/fake_remote.rs b/server/src/test_support/fake_remote.rs
index 02d11f88..e32a88a1 100644
--- a/server/src/test_support/fake_remote.rs
+++ b/server/src/test_support/fake_remote.rs
@@ -1,4 +1,4 @@
-use std::{collections::HashMap, sync::Arc, time::Duration};
+use std::{sync::Arc, time::Duration};
use anyhow::{bail, Error};
use serde::Deserialize;
@@ -129,7 +129,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
let mut vmid = 100;
for _ in 0..self.nr_of_vms {
- vmid = vmid + 1;
+ vmid += 1;
result.push(ClusterResource {
cgroup_mode: None,
content: None,
@@ -163,7 +163,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
}
for _ in 0..self.nr_of_cts {
- vmid = vmid + 1;
+ vmid += 1;
result.push(ClusterResource {
cgroup_mode: None,
content: None,
@@ -358,7 +358,6 @@ impl pve_api_types::client::PveClient for FakePveClient {
async fn list_nodes(&self) -> Result<Vec<ClusterNodeIndexResponse>, proxmox_client::Error> {
tokio::time::sleep(Duration::from_millis(self.api_delay_ms as u64)).await;
Ok((0..self.nr_of_nodes)
- .into_iter()
.map(|i| ClusterNodeIndexResponse {
node: format!("pve-{i}"),
cpu: None,
@@ -415,7 +414,6 @@ impl pve_api_types::client::PveClient for FakePveClient {
let number_of_tasks = limit.min(number_of_tasks as u64);
Ok((0..number_of_tasks)
- .into_iter()
.map(|i| make_task(now - i as i64 * NEW_TASK_EVERY * 60))
.collect())
}
--
2.47.2
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-08-20 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 12:43 [pdm-devel] [PATCH proxmox-datacenter-manager v7 0/7] remote task cache fetching task / better cache backend Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 1/7] remote tasks: implement improved cache for remote tasks Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 2/7] remote tasks: add background task for task polling, use new task cache Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 3/7] pdm-api-types: remote tasks: add new_from_str constructor for TaskStateType Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 4/7] fake remote: make the fake_remote feature compile again Lukas Wagner
2025-08-20 12:43 ` Lukas Wagner [this message]
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 6/7] remote tasks: task cache: create `active` file in init Lukas Wagner
2025-08-20 12:43 ` [pdm-devel] [PATCH proxmox-datacenter-manager v7 7/7] remote tasks: log error in case of task panic, instead of cancelling all tasks Lukas Wagner
2025-08-21 9:20 ` [pdm-devel] applied: [PATCH proxmox-datacenter-manager v7 0/7] remote task cache fetching task / better cache backend Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820124329.220124-6-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.