all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-gui-tests 1/1] fabrics: add screenshots for IS-IS fabric and nodes
Date: Tue, 19 Aug 2025 15:19:08 +0200	[thread overview]
Message-ID: <20250819131916.324392-10-g.goller@proxmox.com> (raw)
In-Reply-To: <20250819131916.324392-1-g.goller@proxmox.com>

Add IS-IS fabric and node screenshots.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 create_fabrics_screenshots | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/create_fabrics_screenshots b/create_fabrics_screenshots
index a83bb222d44b..c0e67f68063c 100755
--- a/create_fabrics_screenshots
+++ b/create_fabrics_screenshots
@@ -14,6 +14,7 @@ sub prepare_fabrics {
     my ($conn) = @_;
     eval {
         # might not exist, so ignore any errors
+        $conn->delete("/cluster/sdn/fabrics/fabric/test3");
         $conn->delete("/cluster/sdn/fabrics/fabric/test2");
         $conn->delete("/cluster/sdn/fabrics/fabric/test1");
     };
@@ -30,14 +31,24 @@ sub prepare_fabrics {
         ip_prefix => "198.51.100.0/24",
         protocol => "ospf",
     };
+    my $isis = {
+        id => "test3",
+        ip_prefix => "192.0.15.0/24",
+        hello_interval => "1",
+        protocol => "isis",
+    };
     $conn->post("/cluster/sdn/fabrics/fabric", $openfabric);
     $conn->post("/cluster/sdn/fabrics/fabric", $ospf);
+    $conn->post("/cluster/sdn/fabrics/fabric", $isis);
 }
 
 sub prepare_nodes {
     my ($conn) = @_;
     eval {
         # might not exist, so ignore any errors
+        $conn->delete("/cluster/sdn/fabrics/node/test3/pve0");
+        $conn->delete("/cluster/sdn/fabrics/node/test3/pve1");
+        $conn->delete("/cluster/sdn/fabrics/node/test3/pve2");
         $conn->delete("/cluster/sdn/fabrics/node/test2/pve0");
         $conn->delete("/cluster/sdn/fabrics/node/test2/pve1");
         $conn->delete("/cluster/sdn/fabrics/node/test2/pve2");
@@ -53,6 +64,7 @@ sub prepare_nodes {
         my $last_octet = $i + 1;
         my $ospf_iface = ($i * 2) + 19;
         my $openfabric_iface = ($i * 2) + 25;
+        my $isis_iface = ($i * 2) + 30;
         
         my $ospf_node = {
             node_id => $node_name,
@@ -72,9 +84,19 @@ sub prepare_nodes {
             ],
             protocol => "openfabric",
         };
+        my $isis_node = {
+            node_id => $node_name,
+            ip => "192.0.15.$last_octet",
+            interfaces => [
+                "name=ens$isis_iface",
+                "name=ens" . ($isis_iface + 1)
+            ],
+            protocol => "isis",
+        };
         
         $conn->post("/cluster/sdn/fabrics/node/test1/", $openfabric_node);
         $conn->post("/cluster/sdn/fabrics/node/test2/", $ospf_node);
+        $conn->post("/cluster/sdn/fabrics/node/test3/", $isis_node);
     }
 }
 
@@ -131,6 +153,18 @@ sub create_fabrics_ui_screenshots {
     $gui->element_screenshot("gui-datacenter-create-fabric-openfabric.png", $window);
     $gui->window_close($window);
 
+    $menu = $gui->find_button('Add Fabric', $panel)->click();
+    $gui->find_menu_item('IS-IS')->click();
+
+    $window = $gui->find_dialog("Create: IS-IS");
+    $gui->setValue($window, 'id', 'test3');
+    $gui->setValue($window, 'ip_prefix', '192.0.2.0/24');
+    $gui->setValue($window, 'hello_interval', '1');
+
+    $gui->element_screenshot("gui-datacenter-create-fabric-isis.png", $window);
+    $gui->window_close($window);
+
+
     $menu = $gui->find_button('Add Fabric', $panel)->click();
     $gui->find_menu_item('OSPF')->click();
 
@@ -164,6 +198,15 @@ sub create_fabrics_ui_screenshots {
     $gui->element_screenshot("gui-datacenter-create-node-ospf.png", $window);
     $gui->window_close($window);
 
+    open_add_node_panel($gui, "isis");
+    sleep_ms(500);
+
+    $window = $gui->find_dialog("Create: Node");
+    $gui->setValue($window, 'ip', '198.51.100.1');
+    select_interfaces($gui, "ens19", "ens20");
+    $gui->element_screenshot("gui-datacenter-create-node-isis.png", $window);
+    $gui->window_close($window);
+
     # get fabric overview
     prepare_nodes($conn);
     sleep_ms(250);
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-08-19 13:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 13:18 [pve-devel] [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs, -perl-rs} 0/9] Add IS-IS protocol to fabrics Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH proxmox-ve-rs 1/3] frr: add IS-IS frr configuration types Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH proxmox-ve-rs 2/3] ve-config: add IS-IS fabric config parsing and frr config generation Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH proxmox-ve-rs 3/3] ve-config: add integration tests for IS-IS fabrics Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH proxmox-perl-rs 1/1] pve-rs: fabrics: add IS-IS protocol ifupdown config generation Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH pve-manager 1/2] fabrics: add IS-IS panels Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH pve-manager 2/2] sdn: add warning about IS-IS controller deprecation Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH pve-network 1/1] fabrics: add IS-IS api types Gabriel Goller
2025-08-19 13:19 ` [pve-devel] [PATCH pve-docs 1/1] sdn: add section about IS-IS fabric Gabriel Goller
2025-08-19 13:19 ` Gabriel Goller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250819131916.324392-10-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal