From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/3] pbs3to4: fix logic error and typo in log message
Date: Mon, 18 Aug 2025 21:40:24 +0200 [thread overview]
Message-ID: <20250818194026.840749-2-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20250818194026.840749-1-s.ivanov@proxmox.com>
/usr/share/doc/systemd-boot/changelog.Debian.gz existing indicates
that system-boot is installed (the `!` was in error).
additionally fix a typo in the log message.
Fixes: 94cc9903 ("bin: pbs3to4: adapt boot-loader checks to trixie")
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/bin/pbs3to4.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/bin/pbs3to4.rs b/src/bin/pbs3to4.rs
index 2e6ea933..5df960a3 100644
--- a/src/bin/pbs3to4.rs
+++ b/src/bin/pbs3to4.rs
@@ -207,7 +207,7 @@ impl Checker {
.log_info("Checking bootloader configuration...")?;
if !Path::new("/sys/firmware/efi").is_dir() {
- if !Path::new("/usr/share/doc/systemd-boot/changelog.Debian.gz").is_file() {
+ if Path::new("/usr/share/doc/systemd-boot/changelog.Debian.gz").is_file() {
self.output.log_info(
"systemd-boot package installed on legacy-boot system is not \
necessary, consider removing it",
@@ -215,7 +215,7 @@ impl Checker {
return Ok(());
}
self.output
- .log_skip("System booted in legacy-mode - no need for additional pacckages.")?;
+ .log_skip("System booted in legacy-mode - no need for additional packages.")?;
return Ok(());
}
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-18 19:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 19:40 [pbs-devel] [PATCH proxmox-backup 0/3] pbs3to4: rework bootloader checks Stoiko Ivanov
2025-08-18 19:40 ` Stoiko Ivanov [this message]
2025-08-18 19:40 ` [pbs-devel] [PATCH proxmox-backup 2/3] pbs3to4: use boolean variable for systemd-boot installation state Stoiko Ivanov
2025-08-18 19:40 ` [pbs-devel] [PATCH proxmox-backup 3/3] pbs3to4: bootloader: only allow systemd-boot before upgrade when used Stoiko Ivanov
2025-08-21 14:18 ` [pbs-devel] superseded: [PATCH proxmox-backup 0/3] pbs3to4: rework bootloader checks Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818194026.840749-2-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.