all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v2 03/21] server: connection: add probe_tls_connection helper
Date: Mon, 18 Aug 2025 15:30:26 +0200	[thread overview]
Message-ID: <20250818133044.2816336-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250818133044.2816336-1-d.csapak@proxmox.com>

this is intended to help us probe a remote/host before using it to check
whether the tls connection is working fine, or it returns the
certificate information so we can show it to the user.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 server/src/connection.rs | 79 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)

diff --git a/server/src/connection.rs b/server/src/connection.rs
index 7d5027f..1cf3b57 100644
--- a/server/src/connection.rs
+++ b/server/src/connection.rs
@@ -15,8 +15,10 @@ use std::time::{Duration, SystemTime};
 use anyhow::{bail, format_err, Error};
 use http::uri::Authority;
 use http::Method;
+use openssl::x509::X509StoreContextRef;
 use serde::Serialize;
 
+use proxmox_acme_api::CertificateInfo;
 use proxmox_client::{Client, HttpApiClient, HttpApiResponse, HttpApiResponseStream, TlsOptions};
 
 use pdm_api_types::remotes::{NodeUrl, Remote, RemoteType};
@@ -799,3 +801,80 @@ impl HttpApiClient for MultiClient {
         try_request! { self, method, path_and_query, params, streaming_request }
     }
 }
+
+/// Checks TLS connection to the given remote
+///
+/// Returns `Ok(None)` if connecting with the given parameters works
+/// Returns `Ok(Some(cert))` if no fingerprint was given and some certificate could not be validated
+/// Returns `Err(err)` if some other error occurred
+///
+/// # Example
+///
+/// ```
+/// use server::connection::probe_tls_connection;
+/// use pdm_api_types::remotes::RemoteType;
+///
+/// # async fn function() {
+/// let result = probe_tls_connection(RemoteType::Pve, "192.168.2.100".to_string(), None).await;
+/// match result {
+///     Ok(None) => { /* everything ok */ },
+///     Ok(Some(cert)) => { /* do something with cert */ },
+///     Err(err) => { /* do something with error */ },
+/// }
+/// # }
+/// ```
+pub async fn probe_tls_connection(
+    remote_type: RemoteType,
+    hostname: String,
+    fingerprint: Option<String>,
+) -> Result<Option<CertificateInfo>, Error> {
+    let host_port: Authority = hostname.parse()?;
+
+    let uri: http::uri::Uri = format!(
+        "https://{}:{}",
+        host_port.host(),
+        host_port.port_u16().unwrap_or(remote_type.default_port())
+    )
+    .parse()?;
+
+    // to save the invalid cert we find
+    let invalid_cert = Arc::new(StdMutex::new(None));
+
+    let options = if let Some(fp) = &fingerprint {
+        TlsOptions::parse_fingerprint(fp)?
+    } else {
+        TlsOptions::Callback(Box::new({
+            let invalid_cert = invalid_cert.clone();
+            move |valid: bool, chain: &mut X509StoreContextRef| {
+                if let Some(cert) = chain.current_cert() {
+                    if !valid {
+                        let cert = cert.to_pem().map(|pem| CertificateInfo::from_pem("", &pem));
+                        *invalid_cert.lock().unwrap() = Some(cert);
+                    }
+                }
+                true
+            }
+        }))
+    };
+    let client = proxmox_client::Client::with_options(uri, options, Default::default())?;
+
+    // set fake auth info. we don't need any, but the proxmox client will return unauthenticated if
+    // none is set.
+    client.set_authentication(proxmox_client::Token {
+        userid: "".to_string(),
+        value: "".to_string(),
+        prefix: "".to_string(),
+        perl_compat: false,
+    });
+
+    client.request(Method::GET, "/", None::<()>).await?;
+
+    let cert = invalid_cert.lock().unwrap().take();
+    if let Some(cert) = cert {
+        let cert = cert?;
+        let cert = cert?;
+        Ok(Some(cert))
+    } else {
+        Ok(None)
+    }
+}
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-08-18 13:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 13:30 [pdm-devel] [PATCH datacenter-manager v2 00/21] improve remote wizard Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 01/21] server/ui: pve: change 'realm list' api call to GET Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 02/21] api types: RemoteType: put default port info to the type Dominik Csapak
2025-08-18 13:30 ` Dominik Csapak [this message]
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 04/21] server/ui: pve api: extend 'scan' so it can probe the tls connection Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 05/21] pdm-client: add scan_remote and probe_tls methods Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 06/21] ui: remotes: node url list: add placeholder and clear trigger Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 07/21] ui: rmeotes: node url list: make column header clearer Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 08/21] ui: remotes: node url list: handle changing default Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 09/21] ui: pve wizard: rename 'realm' variable to 'info' Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 10/21] ui: pve wizard: summary: add default text for fingerprint Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 11/21] ui: pve wizard: nodes: improve info text Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 12/21] ui: pve wizard: nodes: probe hosts to verify fingerprint settings Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 13/21] ui: pve wizard: info: use pdm_client for scanning Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 14/21] ui: pve wizard: info: detect hostname and fingerprint Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 15/21] ui: pve wizard: info: remove manual scan button Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 16/21] ui: widget: add pve realm selector Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 17/21] ui: pve wizard: info: use " Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 18/21] ui: pve wizard: connect: factor out normalize_hostname Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 19/21] ui: pve wizard: connect: move connection logic to next button Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 20/21] ui: pve wizard: connect: use scan api endpoint instead of realms Dominik Csapak
2025-08-18 13:30 ` [pdm-devel] [PATCH datacenter-manager v2 21/21] ui: pve wizard: connect: add certificate confirmation dialog Dominik Csapak
2025-08-19 12:14 ` [pdm-devel] [PATCH datacenter-manager v2 00/21] improve remote wizard Lukas Wagner
2025-08-21  8:48 ` [pdm-devel] superseded: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818133044.2816336-4-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal