From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v5 15/23] api: add endpoint to trigger metric collection
Date: Thu, 14 Aug 2025 15:31:34 +0200 [thread overview]
Message-ID: <20250814133142.386650-16-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250814133142.386650-1-l.wagner@proxmox.com>
This one lives under /metric-collection/trigger.
Doing a POST will trigger metric collection for a remote provided in the
'remote' parameter, or all remotes if the parameter is not provided.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
server/src/api/metric_collection.rs | 35 +++++++++++++++++++++++++++++
server/src/api/mod.rs | 2 ++
2 files changed, 37 insertions(+)
create mode 100644 server/src/api/metric_collection.rs
diff --git a/server/src/api/metric_collection.rs b/server/src/api/metric_collection.rs
new file mode 100644
index 00000000..1a9e0e28
--- /dev/null
+++ b/server/src/api/metric_collection.rs
@@ -0,0 +1,35 @@
+use anyhow::Error;
+
+use pdm_api_types::remotes::REMOTE_ID_SCHEMA;
+use proxmox_router::{Router, SubdirMap};
+use proxmox_schema::api;
+use proxmox_sortable_macro::sortable;
+
+pub const ROUTER: Router = Router::new().subdirs(SUBDIRS);
+
+#[sortable]
+const SUBDIRS: SubdirMap = &sorted!([(
+ "trigger",
+ &Router::new().post(&API_METHOD_TRIGGER_METRIC_COLLECTION)
+),]);
+
+#[api(
+ input: {
+ properties: {
+ remote: {
+ schema: REMOTE_ID_SCHEMA,
+ optional: true,
+ },
+ },
+ },
+)]
+/// Trigger metric collection for a provided remote or for all remotes if no remote is passed.
+pub async fn trigger_metric_collection(remote: Option<String>) -> Result<(), Error> {
+ if let Some(remote) = remote {
+ crate::metric_collection::trigger_metric_collection_for_remote(remote).await?;
+ } else {
+ crate::metric_collection::trigger_metric_collection().await?;
+ }
+
+ Ok(())
+}
diff --git a/server/src/api/mod.rs b/server/src/api/mod.rs
index 6c4831b4..ff875fc8 100644
--- a/server/src/api/mod.rs
+++ b/server/src/api/mod.rs
@@ -9,6 +9,7 @@ use proxmox_sortable_macro::sortable;
pub mod access;
pub mod config;
+pub mod metric_collection;
pub mod nodes;
pub mod pbs;
pub mod pve;
@@ -21,6 +22,7 @@ mod rrd_common;
const SUBDIRS: SubdirMap = &sorted!([
("access", &access::ROUTER),
("config", &config::ROUTER),
+ ("metric-collection", &metric_collection::ROUTER),
("ping", &Router::new().get(&API_METHOD_PING)),
("pve", &pve::ROUTER),
("pbs", &pbs::ROUTER),
--
2.47.2
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-08-14 13:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 13:31 [pdm-devel] [PATCH proxmox-datacenter-manager v5 00/23] metric collection improvements (concurrency, API, CLI) Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 01/23] metric collection: split top_entities split into separate module Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 02/23] metric collection: save metric data to RRD in separate task Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 03/23] metric collection: rework metric poll task Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 04/23] metric collection: persist state after metric collection Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 05/23] metric collection: skip if last_collection < MIN_COLLECTION_INTERVAL Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 06/23] metric collection: collect overdue metrics on startup/timer change Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 07/23] metric collection: add tests for the fetch_remotes function Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 08/23] metric collection: add test for fetch_overdue Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 09/23] metric collection: pass rrd cache instance as function parameter Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 10/23] metric collection: add test for rrd task Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 11/23] metric collection: wrap rrd_cache::Cache in a struct Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 12/23] metric collection: record remote response time in metric database Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 13/23] metric collection: save time needed for collection run to RRD Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 14/23] metric collection: periodically clean removed remotes from statefile Lukas Wagner
2025-08-14 13:31 ` Lukas Wagner [this message]
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 16/23] api: remotes: trigger immediate metric collection for newly added nodes Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 17/23] api: add api for querying metric collection RRD data Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 18/23] api: metric-collection: add status endpoint Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 19/23] pdm-client: add metric collection API methods Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 20/23] cli: add commands for metric-collection trigger and status Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 21/23] metric collection: factor out handle_tick and handle_control_message fns Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 22/23] metric collection: skip missed timer ticks Lukas Wagner
2025-08-14 13:31 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 23/23] metric collection: use JoinSet instead of joining from handles in a Vec Lukas Wagner
2025-08-21 9:39 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 00/23] metric collection improvements (concurrency, API, CLI) Dominik Csapak
2025-08-21 9:55 ` [pdm-devel] superseded: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814133142.386650-16-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.