From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-perl-rs 2/3] fabrics: add function to get all routes distributed by the fabrics
Date: Wed, 13 Aug 2025 15:30:08 +0200 [thread overview]
Message-ID: <20250813133023.288351-3-g.goller@proxmox.com> (raw)
In-Reply-To: <20250813133023.288351-1-g.goller@proxmox.com>
Add a function that returns a list of all the routes which are
distributed using the fabrics. For this we again need to read the config
(in order to get the interface names and thus connect the fabric to the
discovered route) and we need to query frr (using vtysh) for all the
routes (ipv4 and ipv6) distributed by a specific protocol (once for
openfabric and once for ospf). This method is used in the
FabricContentView so that clicking on the fabric resource shows the
routes distributed by the fabric.
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
pve-rs/src/bindings/sdn/fabrics.rs | 156 +++++++++++++++++++++++++++++
1 file changed, 156 insertions(+)
diff --git a/pve-rs/src/bindings/sdn/fabrics.rs b/pve-rs/src/bindings/sdn/fabrics.rs
index 03bc597e13ef..e211ce4af92f 100644
--- a/pve-rs/src/bindings/sdn/fabrics.rs
+++ b/pve-rs/src/bindings/sdn/fabrics.rs
@@ -597,6 +597,18 @@ pub mod pve_rs_sdn_fabrics {
use serde::{Deserialize, Serialize};
+ /// The status of a route.
+ ///
+ /// Contains the route, the fabric and protocol it belongs to and some extra nexthop
+ /// information.
+ #[derive(Debug, Serialize)]
+ pub struct RouteStatus {
+ route: String,
+ via: Vec<String>,
+ fabric_id: FabricId,
+ protocol: Protocol,
+ }
+
/// Protocol
#[derive(Debug, Serialize, Clone, Copy)]
pub enum Protocol {
@@ -642,6 +654,94 @@ pub mod pve_rs_sdn_fabrics {
pub ospf: Routes,
}
+ impl TryInto<Vec<RouteStatus>> for RoutesParsed {
+ type Error = anyhow::Error;
+
+ fn try_into(self) -> Result<Vec<RouteStatus>, Self::Error> {
+ let hostname = proxmox_sys::nodename();
+
+ // to associate a route to a fabric, we get all the interfaces which are associated
+ // with a fabric on this node and compare them with the interfaces on the route.
+ let raw_config = std::fs::read_to_string("/etc/pve/sdn/fabrics.cfg")?;
+ let config = FabricConfig::parse_section_config(&raw_config)?;
+
+ let mut stats: Vec<RouteStatus> = Vec::new();
+
+ for (nodeid, node) in config.values().flat_map(|entry| {
+ entry
+ .nodes()
+ .map(|(id, node)| (id.to_string(), node.clone()))
+ }) {
+ if nodeid != hostname {
+ continue;
+ }
+ let fabric_id = node.id().fabric_id().clone();
+
+ let current_protocol = match &node {
+ ConfigNode::Openfabric(_) => Protocol::Openfabric,
+ ConfigNode::Ospf(_) => Protocol::Ospf,
+ };
+
+ // get interfaces
+ let interface_names: HashSet<String> = match node {
+ ConfigNode::Openfabric(n) => n
+ .properties()
+ .interfaces()
+ .map(|i| i.name().to_string())
+ .collect(),
+ ConfigNode::Ospf(n) => n
+ .properties()
+ .interfaces()
+ .map(|i| i.name().to_string())
+ .collect(),
+ };
+
+ let mut all_routes = HashMap::new();
+ match current_protocol {
+ Protocol::Openfabric => all_routes.extend(&self.openfabric.0),
+ Protocol::Ospf => all_routes.extend(&self.ospf.0),
+ }
+
+ for (route_key, route_list) in all_routes {
+ let mut route_belongs_to_fabric = false;
+ for route in route_list {
+ for nexthop in &route.nexthops {
+ if interface_names.contains(&nexthop.interface_name) {
+ route_belongs_to_fabric = true;
+ break;
+ }
+ }
+ if route_belongs_to_fabric {
+ break;
+ }
+ }
+
+ if route_belongs_to_fabric {
+ let mut via_list = Vec::new();
+ for route in route_list {
+ for nexthop in &route.nexthops {
+ let via = if let Some(ip) = nexthop.ip {
+ ip.to_string()
+ } else {
+ nexthop.interface_name.clone()
+ };
+ via_list.push(via);
+ }
+ }
+
+ stats.push(RouteStatus {
+ route: route_key.to_string(),
+ via: via_list,
+ protocol: current_protocol,
+ fabric_id: fabric_id.clone(),
+ });
+ }
+ }
+ }
+ Ok(stats)
+ }
+ }
+
impl TryInto<HashMap<FabricId, Status>> for RoutesParsed {
type Error = anyhow::Error;
@@ -816,6 +916,62 @@ pub mod pve_rs_sdn_fabrics {
pub struct Routes(pub HashMap<Cidr, Vec<Route>>);
}
+ /// Get all the routes for all the fabrics on this node.
+ ///
+ /// Use FRR to get all the routes that have been inserted by either `openfabric` or 'ospf` and
+ /// associate them with the respective fabric by checking the interface they point to. Return a
+ /// single array with all routes.
+ #[export]
+ fn routes() -> Result<Vec<status::RouteStatus>, Error> {
+ let openfabric_ipv4_routes_string = String::from_utf8(
+ Command::new("sh")
+ .args(["-c", "vtysh -c 'show ip route openfabric json'"])
+ .output()?
+ .stdout,
+ )?;
+
+ let openfabric_ipv6_routes_string = String::from_utf8(
+ Command::new("sh")
+ .args(["-c", "vtysh -c 'show ipv6 route openfabric json'"])
+ .output()?
+ .stdout,
+ )?;
+
+ let ospf_routes_string = String::from_utf8(
+ Command::new("sh")
+ .args(["-c", "vtysh -c 'show ip route ospf json'"])
+ .output()?
+ .stdout,
+ )?;
+
+ let mut openfabric_routes: status::Routes = if openfabric_ipv4_routes_string.is_empty() {
+ status::Routes::default()
+ } else {
+ serde_json::from_str(&openfabric_ipv4_routes_string)
+ .with_context(|| "error parsing openfabric ipv4 routes")?
+ };
+ if !openfabric_ipv6_routes_string.is_empty() {
+ let openfabric_ipv6_routes: status::Routes =
+ serde_json::from_str(&openfabric_ipv6_routes_string)
+ .with_context(|| "error parsing openfabric ipv6 routes")?;
+ openfabric_routes.0.extend(openfabric_ipv6_routes.0);
+ }
+
+ let ospf_routes: status::Routes = if ospf_routes_string.is_empty() {
+ status::Routes::default()
+ } else {
+ serde_json::from_str(&ospf_routes_string)
+ .with_context(|| "error parsing ospf routes")?
+ };
+
+ let route_status = status::RoutesParsed {
+ openfabric: openfabric_routes,
+ ospf: ospf_routes,
+ };
+
+ route_status.try_into()
+ }
+
/// Return the status of all fabrics on this node.
///
/// Go through all fabrics in the config, then filter out the ones that exist on this node.
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-13 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 13:30 [pve-devel] [PATCH manager/network/proxmox-perl-rs 0/8] Add fabric status view Gabriel Goller
2025-08-13 13:30 ` [pve-devel] [PATCH proxmox-perl-rs 1/3] fabrics: add function to get status of fabric Gabriel Goller
2025-08-13 13:30 ` Gabriel Goller [this message]
2025-08-13 13:30 ` [pve-devel] [PATCH proxmox-perl-rs 3/3] fabrics: add function to get all neighbors of the fabric Gabriel Goller
2025-08-13 13:30 ` [pve-devel] [PATCH pve-network 1/3] fabrics: add fabrics status to SDN::status function Gabriel Goller
2025-08-13 13:30 ` [pve-devel] [PATCH pve-network 2/3] fabrics: add api endpoint to return fabrics routes Gabriel Goller
2025-08-13 13:30 ` [pve-devel] [PATCH pve-network 3/3] fabrics: add api endpoint to return fabric neighbors Gabriel Goller
2025-08-13 13:30 ` [pve-devel] [PATCH pve-manager 1/2] pvestatd: add fabrics status to pvestatd Gabriel Goller
2025-08-13 13:30 ` [pve-devel] [PATCH pve-manager 2/2] fabrics: add resource view for fabrics Gabriel Goller
2025-08-22 9:01 ` [pve-devel] [PATCH manager/network/proxmox-perl-rs 0/8] Add fabric status view Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813133023.288351-3-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.