all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox{, -network-interface-pinning} v2 0/3] make ip link deserializing more robust
Date: Fri,  8 Aug 2025 12:23:28 +0200	[thread overview]
Message-ID: <20250808102333.121994-1-s.hanreich@proxmox.com> (raw)

As reported in the forum by [1], there are types of interfaces that do not have
a MAC address, which tripped up the previous deserializing logic. Make the ip
link parsing more robust in general, to prevent tripping up on unexpected
interface types / network configuration.

Changes from v1:
* abstracted link_type specific properties into an enum (Thanks @Christian)
* added tests for all links that proved problematic for the old parser (Thanks
  @Christian for providing me with sample output)
* added a small housekeeping patch that adds some documentation to the public
  API

[1] https://forum.proxmox.com/threads/proxmox-backup-proxy-seemingly-crashes-after-being-accessed-through-reverse-proxy-after-update-to-4-0.169313/

proxmox:

Stefan Hanreich (2):
  network-api: properly parse ip link output based on link_type
  config: helper: document public API

 proxmox-network-api/src/config/helper.rs | 277 ++++++++++++++++++++++-
 1 file changed, 266 insertions(+), 11 deletions(-)


proxmox-network-interface-pinning:

Stefan Hanreich (1):
  network-interface-pinning: adapt to optional mac address

 src/main.rs | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)


Summary over all repositories:
  2 files changed, 283 insertions(+), 21 deletions(-)

-- 
Generated by git-murpp 0.8.0

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2025-08-08 10:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 10:23 Stefan Hanreich [this message]
2025-08-08 10:23 ` [pbs-devel] [PATCH proxmox v2 1/2] network-api: properly parse ip link output based on link_type Stefan Hanreich
2025-08-08 10:23 ` [pbs-devel] [PATCH proxmox v2 2/2] config: helper: document public API Stefan Hanreich
2025-08-08 10:23 ` [pbs-devel] [PATCH proxmox-network-interface-pinning v2 1/1] network-interface-pinning: adapt to optional mac address Stefan Hanreich
2025-08-08 12:48 ` [pbs-devel] [PATCH proxmox{, -network-interface-pinning} v2 0/3] make ip link deserializing more robust Christian Ebner
2025-08-11 12:43 ` [pbs-devel] applied-series: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250808102333.121994-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal