From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] 8 to 9: use more robust systemd version parsing regex from pve-container
Date: Wed, 6 Aug 2025 15:48:43 +0200 [thread overview]
Message-ID: <20250806134843.266183-1-s.sterz@proxmox.com> (raw)
previously some distrubtions could not be parsed here, leading to
reports that containers are not compatible with the dropped cgroup
support. however, this was due to a over sensitive regex. instead use
the more robust version we already use for pve-container [1].
this was reported for an OpenSUSE Slowroll container on the forum:
https://forum.proxmox.com/threads/169302/
[1]: https://git.proxmox.com/?p=pve-manager.git;f=PVE/CLI/pve8to9.pm;h=994189f1#l1285
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
PVE/CLI/pve8to9.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 994189f13..a7ee842de 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1282,7 +1282,8 @@ sub check_containers_cgroup_compat {
last if defined($libsd);
}
if (
- defined($libsd) && $libsd =~ /libsystemd-shared-(\d+)(\.\d-\d)?(\.fc\d\d)?\.so/
+ defined($libsd)
+ && $libsd =~ /libsystemd-shared-(\d+)(?:[-.][a-zA-Z0-9]+)*\.so:?$/
) {
return $1;
}
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-08-06 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 13:48 Shannon Sterz [this message]
2025-08-07 12:56 ` Fiona Ebner
2025-08-07 14:23 ` [pve-devel] Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250806134843.266183-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.