From: Fiona Ebner <f.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] pbs3to4: clippy: allow always true comparision against minimal value
Date: Wed, 6 Aug 2025 12:07:03 +0200 [thread overview]
Message-ID: <20250806100941.59272-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250806100941.59272-1-f.ebner@proxmox.com>
MIN_PBS_PKGREL is a constant that is zero, so the check is currently
superfluous, but that might not always be the case.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/bin/pbs3to4.rs | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/bin/pbs3to4.rs b/src/bin/pbs3to4.rs
index 46aa0a63..a60c77e2 100644
--- a/src/bin/pbs3to4.rs
+++ b/src/bin/pbs3to4.rs
@@ -98,6 +98,9 @@ impl Checker {
let min_version = format!("{MIN_PBS_MAJOR}.{MIN_PBS_MINOR}.{MIN_PBS_PKGREL}");
+ // MIN_PBS_PKGREL is currently zero, making the comparison further below
+ // superfluous, but this might not always be the case
+ #[allow(clippy::absurd_extreme_comparisons)]
if maj > MIN_PBS_MAJOR {
self.output
.log_pass(format!("Already upgraded to Proxmox Backup Server {maj}"))?;
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-06 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 10:07 [pbs-devel] [PATCH-SERIES proxmox-backup 0/2] pbs3to4: add check for spelling of pbs-test repo Fiona Ebner
2025-08-06 10:07 ` [pbs-devel] [PATCH proxmox-backup 1/2] " Fiona Ebner
2025-08-06 10:07 ` Fiona Ebner [this message]
2025-08-06 11:22 ` [pbs-devel] applied-series: [PATCH-SERIES proxmox-backup 0/2] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250806100941.59272-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.