From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC installer] install: do not create deprecated /etc/timezone
Date: Tue, 5 Aug 2025 23:40:06 +0200 [thread overview]
Message-ID: <20250805214006.1111543-1-s.ivanov@proxmox.com> (raw)
starting with tzdata version 2024b-5 [0] the package does not create
/etc/timezone anymore (background is quite well explained in
/usr/share/doc/tzdata/NEWS.Debian.gz:
```
Previously, the tzdata package in Debian used the /etc/timezone file to
configure the system's timezone. This method is not supported by systemd
and certain desktop environments, which instead only change the
/etc/localtime symlink to point to a file in /usr/share/zoneinfo.
....
In a future release, the /etc/timezone file will be automatically
removed ... The debian-installer from Trixie also no longer
creates this file.
```
align our installer with debian's installer.
[0] https://metadata.ftp-master.debian.org/changelogs//main/t/tzdata/tzdata_2025b-4_changelog
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
I would NOT recommend adding this patch now - we'd need to check where our
code relies on /etc/timezone being present (PVE/INotify.pm creates it IIRC,
proxmox-time create and proxmox-backup have a fallback to /etc/localtime) -
but that was just a very cursory glance at a grep '/etc/timezone' in my
source-dir).
Proxmox/Install.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 9cb88bc..fb23f7f 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1299,7 +1299,6 @@ _EOD
my $timezone = Proxmox::Install::Config::get_timezone();
unlink("$targetdir/etc/localtime");
symlink("/usr/share/zoneinfo/$timezone", "$targetdir/etc/localtime");
- file_write_all("$targetdir/etc/timezone", "$timezone\n");
unlink "$targetdir/etc/mailname";
$postfix_main_cf =~ s/__FQDN__/${hostname}.${domain}/;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-08-05 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 21:40 Stoiko Ivanov [this message]
2025-09-17 16:08 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250805214006.1111543-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.