all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] pve8to9: lvm autoactivation: rephrase misleading message and fix typo
Date: Tue,  5 Aug 2025 09:42:05 +0200	[thread overview]
Message-ID: <20250805074220.28307-1-f.weber@proxmox.com> (raw)

Currently, the message implies that *disabling* autoactivation might
cause issues, which is not the case.

While at it, fix a minor typo.

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
 PVE/CLI/pve8to9.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index bb0dc94d..5784701a 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1822,7 +1822,7 @@ sub check_lvm_autoactivation {
             ? "Some affected volumes are on shared LVM storages, which has known issues (Bugzilla"
             . " #4997). Disabling autoactivation for those is strongly recommended!"
             : "All volumes with autoactivations reside on local storage, where this normally does"
-            . " not causes any issues.";
+            . " not cause any issues.";
         $_log->(
             "Starting with PVE 9, autoactivation will be disabled for new LVM/LVM-thin guest"
                 . " volumes. This system has some volumes that still have autoactivation enabled. "
@@ -1832,7 +1832,7 @@ sub check_lvm_autoactivation {
                 . "\n");
     } else {
         log_pass(
-            "No volumes were found that could potentially have issues due to the disabling of LVM autoactivation."
+            "No volumes were found that could potentially have issues due to enabled LVM autoactivation."
         );
     }
 
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


                 reply	other threads:[~2025-08-05  7:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250805074220.28307-1-f.weber@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal