[pve-devel] [PATCH rrd-migration-tool/manager v2 0/2] RRD migration: only skip '.old' extension to better handle storage IDs containing a dot

[pve-devel] [PATCH rrd-migration-tool/manager v2 0/2] RRD migration: only skip '.old' extension to better handle storage IDs containing a dot

[Fiona Ebner]

Storage IDs may contain a dot, which would make the tool ignore data
for them. This does not fix the issue completely, the final corner
case with storages being called called 'something.old' remains.

A warning for storages called '.old' is added to the pve8to9 checker
script. If enough people really run into this issue with such
storages, the migration script will be improved further after the
release of PVE 9. For now, use a straight-forward stop-gap measure to
avoid the fallout from not handling any storage ID with a dot.

Changes in v2:
* Less complicated stop-gap measure for now.

rrd-migration-tool:

Fiona Ebner (1):
  collect rrd files: only skip '.old' extension to better handle storage
    IDs containing a dot

 src/main.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


pve-manager:

Fiona Ebner (1):
  pve8to9: rrd migration: mention storage RRD files for which automatic
    migration doesn't work

 PVE/CLI/pve8to9.pm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)


Summary over all repositories:
  2 files changed, 10 insertions(+), 2 deletions(-)

-- 
Generated by git-murpp 0.5.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH rrd-migration-tool v2 1/2] collect rrd files: only skip '.old' extension to better handle storage IDs containing a dot

[Fiona Ebner]

Storage IDs may contain a dot, which would make the tool ignore data
for them. This does not fix the issue completely, the final corner
case with storages being called called 'something.old' remains.

A warning for storages called '.old' is added to the pve8to9 checker
script. If enough people really run into this issue with such
storages, the migration script will be improved further after the
release of PVE 9. For now, use a straight-forward stop-gap measure to
avoid the fallout from not handling any storage ID with a dot.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Changes in v2:
* Different approach as a less complicated stop-gap measure.

 src/main.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main.rs b/src/main.rs
index 9afd48b..e18551c 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -331,7 +331,7 @@ fn collect_rrd_files(location: &PathBuf) -> Result<Vec<(CString, OsString)>> {
     contents
         .filter(|f| f.is_ok())
         .map(|f| f.unwrap().path())
-        .filter(|f| f.is_file() && f.extension().is_none())
+        .filter(|f| f.is_file() && f.extension().is_none_or(|ext| ext != "old"))
         .for_each(|file| {
             let path = CString::new(file.as_path().as_os_str().as_bytes())
                 .expect("Could not convert path to CString.");
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v2 2/2] pve8to9: rrd migration: mention storage RRD files for which automatic migration doesn't work

[Fiona Ebner]

The RRD migration tool currently has the limitation of not migrating
RRD files for storages with a '.old' suffix. Mention the list of such
storages below the RRD file list and migration command so that users
can adapt before executing the migration command.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v2.

 PVE/CLI/pve8to9.pm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 8c26ddbd..0109fade 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1911,10 +1911,18 @@ sub check_rrd_migration {
                 . join("\n\t ", $old_files->@*)
                 . "\n\tPlease run the following command manually:\n"
                 . "\t/usr/libexec/proxmox/proxmox-rrd-migration-tool --migrate\n");
+
+            my $cfg = PVE::Storage::config();
+            my @unhandled_storages = grep { $_ =~ m|\.old$| } sort keys $cfg->{ids}->%*;
+            if (scalar(@unhandled_storages) > 0) {
+                my $storage_list_txt = join(", ", @unhandled_storages);
+                log_warn("RRD data for the following storages cannot be migrated"
+                    . " automatically: $storage_list_txt\nRename the RRD files to a name without '.old'"
+                    . " before migration and re-add that suffix after migration.");
+            }
         } else {
             log_pass("No old RRD metric files found, normally this means all have been migrated.");
         }
-
     } else {
         log_info("Check space requirements for RRD migration...");
         # multiplier values taken from KiB sizes of old and new RRD files
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH rrd-migration-tool/manager v2 0/2] RRD migration: only skip '.old' extension to better handle storage IDs containing a dot

[Thomas Lamprecht]

Am 04.08.25 um 14:55 schrieb Fiona Ebner:
> Storage IDs may contain a dot, which would make the tool ignore data
> for them. This does not fix the issue completely, the final corner
> case with storages being called called 'something.old' remains.
> 
> A warning for storages called '.old' is added to the pve8to9 checker
> script. If enough people really run into this issue with such
> storages, the migration script will be improved further after the
> release of PVE 9. For now, use a straight-forward stop-gap measure to
> avoid the fallout from not handling any storage ID with a dot.
> 
> Changes in v2:
> * Less complicated stop-gap measure for now.
> 
> rrd-migration-tool:
> 
> Fiona Ebner (1):
>   collect rrd files: only skip '.old' extension to better handle storage
>     IDs containing a dot
> 
>  src/main.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> pve-manager:
> 
> Fiona Ebner (1):
>   pve8to9: rrd migration: mention storage RRD files for which automatic
>     migration doesn't work
> 
>  PVE/CLI/pve8to9.pm | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> 
> Summary over all repositories:
>   2 files changed, 10 insertions(+), 2 deletions(-)
> 


applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel