From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox v3 1/2] s3 client: api types: extend client config by optional provider quirks
Date: Mon, 4 Aug 2025 08:53:28 +0200 [thread overview]
Message-ID: <20250804065331.45272-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250804065331.45272-1-c.ebner@proxmox.com>
Add optional provider specific quirks to the client configuration,
allowing to set a variant of the client to follow some custom
implementation variants.
Add backblaze as first variant, as it does not accept the
`If-None-Match` header in put object requests.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
---
changes since version 2:
- no changes
proxmox-s3-client/src/api_types.rs | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/proxmox-s3-client/src/api_types.rs b/proxmox-s3-client/src/api_types.rs
index 265fedb9..3db6f7a4 100644
--- a/proxmox-s3-client/src/api_types.rs
+++ b/proxmox-s3-client/src/api_types.rs
@@ -80,6 +80,19 @@ pub const S3_BUCKET_NAME_SCHEMA: Schema = StringSchema::new("Bucket name for S3
.max_length(63)
.schema();
+#[api]
+#[derive(Copy, Clone, Deserialize, Serialize, PartialEq, Eq)]
+#[serde(rename_all = "kebab-case")]
+/// Provider specific feature implementation quirks.
+pub enum ProviderQuirks {
+ /// Implementation quirks for Backblaze.
+ Backblaze,
+ /// Implementation quirks for Infomaniak.
+ Infomaniak,
+}
+serde_plain::derive_display_from_serialize!(ProviderQuirks);
+serde_plain::derive_fromstr_from_deserialize!(ProviderQuirks);
+
#[api(
properties: {
endpoint: {
@@ -109,6 +122,10 @@ pub const S3_BUCKET_NAME_SCHEMA: Schema = StringSchema::new("Bucket name for S3
type: u64,
optional: true,
},
+ "provider-quirks": {
+ type: ProviderQuirks,
+ optional: true,
+ },
},
)]
#[derive(Serialize, Deserialize, Updater, Clone, PartialEq)]
@@ -134,6 +151,9 @@ pub struct S3ClientConfig {
/// Rate limit for put requests given as #reqest/s.
#[serde(skip_serializing_if = "Option::is_none")]
pub put_rate_limit: Option<u64>,
+ /// Provider specific feature implementation quirks.
+ #[serde(skip_serializing_if = "Option::is_none")]
+ pub provider_quirks: Option<ProviderQuirks>,
}
impl S3ClientConfig {
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-04 6:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 6:53 [pbs-devel] [PATCH proxmox{, -backup} v3 0/4] s3: extend config by provider-quirks and client options by feature list Christian Ebner
2025-08-04 6:53 ` Christian Ebner [this message]
2025-08-04 6:53 ` [pbs-devel] [PATCH proxmox v3 2/2] s3 client: extend " Christian Ebner
2025-08-04 6:53 ` [pbs-devel] [PATCH proxmox-backup v3 1/2] api: s3 config: allow to update or delete endpoint quirks Christian Ebner
2025-08-04 6:53 ` [pbs-devel] [PATCH proxmox-backup v3 2/2] ui: s3 endpoint: add provider specific quirk selector Christian Ebner
2025-08-04 20:17 ` [pbs-devel] [PATCH proxmox{, -backup} v3 0/4] s3: extend config by provider-quirks and client options by feature list Thomas Lamprecht
2025-08-05 5:58 ` Christian Ebner
2025-08-05 6:15 ` Thomas Lamprecht
2025-08-05 10:52 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804065331.45272-2-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.