From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES rrd-migration-tool 0/2] migrate nodes: fix handling nonexistent nodes
Date: Fri, 1 Aug 2025 15:54:27 +0200 [thread overview]
Message-ID: <20250801135443.133089-1-f.ebner@proxmox.com> (raw)
Use the correct path when skipping a nonexistent node. Before this
series, the presence of a nonexistent node would lead to a failure:
> Error migrating nodes: Not a directory (os error 20)
That is because the path would have a duplicate node name attached,
for example:
> /var/lib/rrdcached/db/pve2-node/nonexistent/nonexistent
Fixing that alone is not enough, there also was a 'continue' missing
to avoid calling do_rrd_migration() with the old node, i.e. to
actually skip it.
Fiona Ebner (2):
d/control: record librust-pretty-assertions-dev build dependency
migrate nodes: fix handling nonexistent nodes
debian/control | 1 +
src/main.rs | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-08-01 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 13:54 Fiona Ebner [this message]
2025-08-01 13:54 ` [pve-devel] [PATCH rrd-migration-tool 1/2] d/control: record librust-pretty-assertions-dev build dependency Fiona Ebner
2025-08-01 13:54 ` [pve-devel] [PATCH rrd-migration-tool 2/2] migrate nodes: fix handling nonexistent nodes Fiona Ebner
2025-08-01 14:52 ` [pve-devel] applied: [PATCH-SERIES rrd-migration-tool 0/2] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801135443.133089-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.