all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager stable8+master] pve8to9: record where legacy spelling of pve-test repository is found
Date: Fri,  1 Aug 2025 13:15:18 +0200	[thread overview]
Message-ID: <20250801111832.76239-1-f.ebner@proxmox.com> (raw)

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

The stable-8 branch needs a 'make tidy' first for this to apply
cleanly.

 PVE/CLI/pve8to9.pm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 4d61cd83..fe3964d1 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1465,7 +1465,8 @@ sub check_apt_repos {
                     $found_pve_test_repo = 1;
                     # just safe one, mismatched suite check will handle multiple different ones already
                     $found_pve_test_repo_suite = $suite;
-                    $found_legacy_spelled_pve_test_repo = 1 if $component eq 'pvetest';
+                    $found_legacy_spelled_pve_test_repo = { where => $where }
+                        if $component eq 'pvetest';
                 }
             }
 
@@ -1530,9 +1531,11 @@ sub check_apt_repos {
         );
         if ($found_legacy_spelled_pve_test_repo) {
             my $_log = $found_pve_test_repo_suite eq $new_suite ? \&log_fail : \&log_warn;
+            my $where = $found_legacy_spelled_pve_test_repo->{where};
             $_log->(
-                "Found legacy spelling 'pvetest' of the pve-test repo. Change the repo to use"
-                    . " 'pve-test' when updating the repos to the '$new_suite' suite for Proxmox VE 9!"
+                "Found legacy spelling 'pvetest' of the pve-test repo $where. Change the repo to"
+                    ." use 'pve-test' when updating the repos to the '$new_suite' suite for Proxmox"
+                    ." VE 9!"
             );
         } elsif ($found_pve_test_repo_suite eq $new_suite) {
             log_pass(
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


                 reply	other threads:[~2025-08-01 11:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250801111832.76239-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal