From: Friedrich Weber <f.weber@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: RRD graphs: display PSI as percent
Date: Thu, 31 Jul 2025 15:51:42 +0200 [thread overview]
Message-ID: <20250731135147.138187-1-f.weber@proxmox.com> (raw)
Pressure stall information are actually in percent. This is not
mentioned explicitly in the documentation, but e.g. in the kernel
source [1]:
> The percentage of wall clock time spent in those compound stall
> states gives pressure numbers between 0 and 100 for each resource,
> where the SOME percentage indicates workload slowdowns and the FULL
> percentage indicates reduced CPU utilization:
>
> %SOME = time(SOME) / period
> %FULL = time(FULL) / period
Thus, also display them as percent in the GUI.
This reverts commit 087af558631b96ba4fdc40548234e4fa5478b354.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/kernel/sched/psi.c?h=v6.16#n52
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
www/manager6/node/Summary.js | 3 +++
www/manager6/panel/GuestSummary.js | 3 +++
2 files changed, 6 insertions(+)
diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js
index c7abd276..9a3f84a4 100644
--- a/www/manager6/node/Summary.js
+++ b/www/manager6/node/Summary.js
@@ -204,6 +204,7 @@ Ext.define('PVE.node.Summary', {
fields: ['pressurecpusome'],
colors: ['#FFD13E', '#A61120'],
store: rrdstore,
+ unit: 'percent',
},
{
xtype: 'proxmoxRRDChart',
@@ -212,6 +213,7 @@ Ext.define('PVE.node.Summary', {
fields: ['pressureiosome', 'pressureiofull'],
colors: ['#FFD13E', '#A61120'],
store: rrdstore,
+ unit: 'percent',
},
{
xtype: 'proxmoxRRDChart',
@@ -220,6 +222,7 @@ Ext.define('PVE.node.Summary', {
fields: ['pressurememorysome', 'pressurememoryfull'],
colors: ['#FFD13E', '#A61120'],
store: rrdstore,
+ unit: 'percent',
},
],
listeners: {
diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js
index 7780d731..f46006b4 100644
--- a/www/manager6/panel/GuestSummary.js
+++ b/www/manager6/panel/GuestSummary.js
@@ -142,6 +142,7 @@ Ext.define('PVE.guest.Summary', {
fields: ['pressurecpusome', 'pressurecpufull'],
colors: ['#FFD13E', '#A61120'],
store: rrdstore,
+ unit: 'percent',
},
{
xtype: 'proxmoxRRDChart',
@@ -151,6 +152,7 @@ Ext.define('PVE.guest.Summary', {
fields: ['pressureiosome', 'pressureiofull'],
colors: ['#FFD13E', '#A61120'],
store: rrdstore,
+ unit: 'percent',
},
{
xtype: 'proxmoxRRDChart',
@@ -160,6 +162,7 @@ Ext.define('PVE.guest.Summary', {
fields: ['pressurememorysome', 'pressurememoryfull'],
colors: ['#FFD13E', '#A61120'],
store: rrdstore,
+ unit: 'percent',
},
);
}
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-07-31 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 13:51 Friedrich Weber [this message]
2025-07-31 13:56 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-31 14:06 ` Friedrich Weber
2025-07-31 14:08 ` Shannon Sterz
2025-07-31 14:09 ` Friedrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731135147.138187-1-f.weber@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.