all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/4] api: status: expose backend type in datastore status list item
Date: Thu, 31 Jul 2025 09:39:47 +0200	[thread overview]
Message-ID: <20250731073950.73526-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250731073950.73526-1-c.ebner@proxmox.com>

Analogous to the mount status, include the backend type in the
datastore status list item. This allows to interpret the provided
data based on the backend type.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/api2/status/mod.rs | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/api2/status/mod.rs b/src/api2/status/mod.rs
index e066a99c7..6f0b2cf8c 100644
--- a/src/api2/status/mod.rs
+++ b/src/api2/status/mod.rs
@@ -10,8 +10,8 @@ use proxmox_schema::api;
 use proxmox_sortable_macro::sortable;
 
 use pbs_api_types::{
-    Authid, DataStoreConfig, DataStoreMountStatus, DataStoreStatusListItem, Operation,
-    PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_BACKUP,
+    Authid, DataStoreConfig, DataStoreMountStatus, DataStoreStatusListItem, DatastoreBackendConfig,
+    DatastoreBackendType, Operation, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_BACKUP,
 };
 
 use pbs_config::CachedUserInfo;
@@ -55,6 +55,10 @@ pub async fn datastore_status(
 
         let store_config = config.lookup::<DataStoreConfig>("datastore", store)?;
 
+        let backend_config: DatastoreBackendConfig =
+            store_config.backend.as_deref().unwrap_or("").parse()?;
+        let backend_type = backend_config.ty.unwrap_or_default();
+
         let mount_status = match get_datastore_mount_status(&store_config) {
             Some(true) => DataStoreMountStatus::Mounted,
             Some(false) => {
@@ -62,6 +66,7 @@ pub async fn datastore_status(
                     store,
                     None,
                     DataStoreMountStatus::NotMounted,
+                    backend_type,
                 ));
                 continue;
             }
@@ -71,7 +76,12 @@ pub async fn datastore_status(
         if !allowed {
             if let Ok(datastore) = DataStore::lookup_datastore(store, Some(Operation::Lookup)) {
                 if can_access_any_namespace(datastore, &auth_id, &user_info) {
-                    list.push(DataStoreStatusListItem::empty(store, None, mount_status));
+                    list.push(DataStoreStatusListItem::empty(
+                        store,
+                        None,
+                        mount_status,
+                        backend_type,
+                    ));
                 }
             }
             continue;
@@ -84,6 +94,7 @@ pub async fn datastore_status(
                     store,
                     Some(err.to_string()),
                     mount_status,
+                    backend_type,
                 ));
                 continue;
             }
@@ -102,6 +113,7 @@ pub async fn datastore_status(
             estimated_full_date: None,
             error: None,
             gc_status: Some(datastore.last_gc_status()),
+            backend_type,
         };
 
         let rrd_dir = format!("datastore/{}", store);
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-07-31  7:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  7:39 [pbs-devel] [RFC proxmox{, -backup} 0/5] switch local storage usage titles based on datastore backend Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: add backend type to datastore's status items Christian Ebner
2025-07-31  7:39 ` Christian Ebner [this message]
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 2/4] datastore: introduce helper to get store's backend type Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 3/4] api: datastore: expose the datastore backend type in the status output Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: Set datastore usage related titles based on backend Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250731073950.73526-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal