all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container] fix #6573: allow userns creation when nesting is enabled
Date: Wed, 30 Jul 2025 08:58:45 +0200	[thread overview]
Message-ID: <20250730065911.33062-1-w.bumiller@proxmox.com> (raw)

This is another difference with the apparmor 4.0 userspace. We need to
explicitly enable user namespaces in the generated profile - at least
when nesting is enabled.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
---
 src/PVE/LXC.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 741bb33..b922ba1 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -595,6 +595,7 @@ sub make_apparmor_config {
 
     # We use abi/4.0 which has its own mqueue class which governs access to /dev/mqueue now.
     # This is currently not default in lxc's profile, so we enable it explicitly.
+    # FIXME: once lxc's profiles are based on abi/4.0 this should not be required.
     $raw .= "lxc.apparmor.raw = allow mqueue,\n";
 
     my @profile_uses;
@@ -612,6 +613,8 @@ sub make_apparmor_config {
     if ($features->{nesting}) {
         push @profile_uses, 'features:nesting';
         $raw .= "lxc.apparmor.allow_nesting = 1\n";
+        # FIXME: once lxc's profiles are based on abi/4.0 this should not be required.
+        $raw .= "lxc.apparmor.raw = allow userns,\n";
     } else {
         # In the default profile in /etc/apparmor.d we patch this in because
         # otherwise a container can for example run `chown` on /sys, breaking
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-07-30  6:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30  6:58 Wolfgang Bumiller [this message]
2025-07-30 11:40 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250730065911.33062-1-w.bumiller@proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal