[pve-devel] [PATCH common/manager v2 0/3] arbitrary prefixes for pinning network interfaces

[Stefan Hanreich <s.hanreich@proxmox.com>]

This patch series lifts the restriction for naming physical interfaces.
Previously we relied on a regex (PHYSICAL_NIC_RE) for determining whether an
interface was physical or not. This patch series changes that, by querying the
kernel for the type of the interface and using that to determine whether an
interface is a physical interface or not. This allows us to use arbitrary names
for physical interfaces, which in turn allows proxmox-network-interface-pinning
to use arbitrary prefixes / target-names when pinning network interfaces.

The main change here is with pvestatd and metric collection, where we used the
regex to determine the type of interface in PullMetric. I introduced a new key
in the netdev hash that indicates the type of interface. Since my knowledge of
this component is almost zero, I'm not sure if this is the proper approach.
Maybe someone with more experience can chime in on possible issues /
improvements.

pve-manager depends on pve-common

Changes from v1 to v2:
* Cache ip link output
* add dependency for pvenetcommit to pvestatd
* use type only to distinguish between physical / virtual interfaces

pve-common:

Stefan Hanreich (1):
  inotify/interfaces: use ip link for detecting physical interfaces

 src/PVE/INotify.pm | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)


pve-manager:

Stefan Hanreich (2):
  pvestatd: pull metric: use ip link to detect physical interfaces
  network-interface-pinning: allow arbitrary names

 PVE/CLI/proxmox_network_interface_pinning.pm |  4 ++--
 PVE/PullMetric.pm                            | 15 ++++++++++++---
 PVE/Service/pvestatd.pm                      | 15 ++++++++++++++-
 services/pvestatd.service                    |  2 +-
 4 files changed, 29 insertions(+), 7 deletions(-)


Summary over all repositories:
  5 files changed, 42 insertions(+), 19 deletions(-)

-- 
Generated by git-murpp 0.8.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel