From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 4/7] datastore: fix clippy warning checking file extension
Date: Mon, 28 Jul 2025 14:40:03 +0200 [thread overview]
Message-ID: <20250728124006.868999-5-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250728124006.868999-1-c.ebner@proxmox.com>
Follow the suggestion and check the file extension instead of relying
on the path to str conversion.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
pbs-datastore/src/datastore.rs | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index e3c0589a4..3b91a3583 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -1798,7 +1798,10 @@ impl DataStore {
};
let atime = atime.duration_since(SystemTime::UNIX_EPOCH)?.as_secs() as i64;
- let bad = chunk_path.as_path().ends_with(".bad");
+ let bad = chunk_path
+ .as_path()
+ .extension()
+ .is_some_and(|ext| ext == "bad");
if atime < min_atime {
if let Some(cache) = self.cache() {
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-28 12:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 12:39 [pbs-devel] [PATCH proxmox-backup 0/7] remove objects from s3 backend on datastore destroy Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 1/7] tree wide: fix useless borrow warnings Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 2/7] client: backup writer: elide lifetime which can be auto inferred Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 3/7] api: tape: fix clippy warning on map iteration Christian Ebner
2025-07-28 12:40 ` Christian Ebner [this message]
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 5/7] datastore: fix clippy warning to use ? on option Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 6/7] datastore: add helper to get s3 client from datastore config Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 7/7] datastore: delete all objects on datastore destroy with remove data Christian Ebner
2025-07-29 13:53 ` [pbs-devel] [PATCH proxmox-backup 0/7] remove objects from s3 backend on datastore destroy Lukas Wagner
2025-07-29 16:54 ` Christian Ebner
2025-07-30 7:59 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728124006.868999-5-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.