all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 0/7] remove objects from s3 backend on datastore destroy
Date: Mon, 28 Jul 2025 14:39:59 +0200	[thread overview]
Message-ID: <20250728124006.868999-1-c.ebner@proxmox.com> (raw)

This patch series makes sure the datastore contents are also removed
from the s3 backend if the datastore is destroyed with the remove all
data flag being set.

The first 6 patches fix clippy warnings and refactor the s3 client from
datastore config generation into a dedicated helper, since the last
patch requires that as well and this would be the third ocurence thereof.

The last patch finally does the object store cleanup if the datastore is
backed by s3 and the data should be removed. This simply clears all
contents starting with the store prefix from the bucket.

Christian Ebner (7):
  tree wide: fix useless borrow warnings
  client: backup writer: elide lifetime which can be auto inferred
  api: tape: fix clippy warning on map iteration
  datastore: fix clippy warning checking file extension
  datastore: fix clippy warning to use ? on option
  datastore: add helper to get s3 client from datastore config
  datastore: delete all objects on datastore destroy with remove data

 pbs-client/src/backup_writer.rs    |   4 +-
 pbs-config/src/datastore.rs        |   2 +-
 pbs-datastore/src/datastore.rs     |  64 +++++++++++++---
 src/api2/config/datastore.rs       | 119 +++++++++--------------------
 src/api2/config/tape_backup_job.rs |   2 +-
 src/api2/tape/restore.rs           |   2 +-
 6 files changed, 97 insertions(+), 96 deletions(-)

-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2025-07-28 12:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28 12:39 Christian Ebner [this message]
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 1/7] tree wide: fix useless borrow warnings Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 2/7] client: backup writer: elide lifetime which can be auto inferred Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 3/7] api: tape: fix clippy warning on map iteration Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 4/7] datastore: fix clippy warning checking file extension Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 5/7] datastore: fix clippy warning to use ? on option Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 6/7] datastore: add helper to get s3 client from datastore config Christian Ebner
2025-07-28 12:40 ` [pbs-devel] [PATCH proxmox-backup 7/7] datastore: delete all objects on datastore destroy with remove data Christian Ebner
2025-07-29 13:53 ` [pbs-devel] [PATCH proxmox-backup 0/7] remove objects from s3 backend on datastore destroy Lukas Wagner
2025-07-29 16:54   ` Christian Ebner
2025-07-30  7:59 ` [pbs-devel] superseded: " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250728124006.868999-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal