all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox{, -backup} 00/10] s3: implement list buckets and use bucket selector for datastore creation
Date: Mon, 28 Jul 2025 08:46:35 +0200	[thread overview]
Message-ID: <20250728064645.158414-1-c.ebner@proxmox.com> (raw)

This patches aim to increase usability for the user by allowing to list
accessible buckets during datastore creation.

For this, the proxmox s3 client is extended by the list buckets method, fetching
accessible buckets from the s3 api. This requires the client instantiation to be
possible without the bucket name, making it therefore optional. Further, the
regex for the config endpoint url must be restricted to have the bucket name
template pattern always at the start of the template. With these changes, it is
then possible to fetch the buckets given the required permissions to do so.

On the proxmox backup server side, the api endpoints to fetch the bucket list
are implemented as well as the corresponding cli command. Finally, the bucket
name field in the datastore edit window is replaced by an s3 bucket selector,
which loads the accessible bucket names via the api.

proxmox:

Christian Ebner (4):
  s3 client: restrict bucket template pattern to start of endpoint url
  s3 client: make bucket name optional in S3 client options
  s3 client: implement list buckets method
  s3 client: api types: add bucket list item type

 proxmox-s3-client/examples/s3_client.rs  |  2 +-
 proxmox-s3-client/src/api_types.rs       | 17 ++++++-
 proxmox-s3-client/src/client.rs          | 39 +++++++++++++---
 proxmox-s3-client/src/response_reader.rs | 58 ++++++++++++++++++++++++
 4 files changed, 108 insertions(+), 8 deletions(-)


proxmox-backup:

Christian Ebner (6):
  ui: fix formatting issues using proxmox-biome
  datastore: wrap bucket name, as in is now optional in the s3 client
  api: admin s3: make store prefix for check command optional
  api: config s3: add bucket list api endpoint
  bin: expose list buckets as proxmox-backup-manager s3 subcommand
  ui: replace bucket field by bucket selector

 pbs-datastore/src/datastore.rs       |  2 +-
 src/api2/admin/s3.rs                 |  6 ++--
 src/api2/config/datastore.rs         |  4 +--
 src/api2/config/s3.rs                | 48 +++++++++++++++++++++++--
 src/bin/proxmox_backup_manager/s3.rs | 28 +++++++++++++--
 www/Makefile                         |  1 +
 www/Utils.js                         |  5 ++-
 www/form/S3BucketSelector.js         | 52 ++++++++++++++++++++++++++++
 www/window/DataStoreEdit.js          | 27 +++++++++++----
 9 files changed, 155 insertions(+), 18 deletions(-)
 create mode 100644 www/form/S3BucketSelector.js


Summary over all repositories:
  13 files changed, 263 insertions(+), 26 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2025-07-28  6:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28  6:46 Christian Ebner [this message]
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox 1/4] s3 client: restrict bucket template pattern to start of endpoint url Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox 2/4] s3 client: make bucket name optional in S3 client options Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox 3/4] s3 client: implement list buckets method Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox 4/4] s3 client: api types: add bucket list item type Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 1/6] ui: fix formatting issues using proxmox-biome Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 2/6] datastore: wrap bucket name, as in is now optional in the s3 client Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 3/6] api: admin s3: make store prefix for check command optional Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 4/6] api: config s3: add bucket list api endpoint Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 5/6] bin: expose list buckets as proxmox-backup-manager s3 subcommand Christian Ebner
2025-07-28  6:46 ` [pbs-devel] [PATCH proxmox-backup 6/6] ui: replace bucket field by bucket selector Christian Ebner
2025-07-30 13:47 ` [pbs-devel] [PATCH proxmox{, -backup} 00/10] s3: implement list buckets and use bucket selector for datastore creation Lukas Wagner
2025-07-30 14:25   ` Christian Ebner
2025-07-30 14:00 ` Lukas Wagner
2025-07-30 14:41 ` [pbs-devel] superseded: " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250728064645.158414-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal