all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v3 3/6] vzdump: use verbose size suffix when logging archive file size
Date: Wed, 23 Jul 2025 13:57:38 +0200	[thread overview]
Message-ID: <20250723115809.96282-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250723115809.96282-1-f.ebner@proxmox.com>

The single-letter suffixes are ambiguous and especially in the context
of disks, the powers of ten are usually used. Use exact suffixes
instead when logging the archive file size.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/VZDump.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index cf71a9fa..d7cce65c 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -240,19 +240,19 @@ sub format_size {
     my $kb = $size / 1024;
 
     if ($kb < 1024) {
-        return int($kb) . "KB";
+        return int($kb) . "KiB";
     }
 
     my $mb = $size / (1024 * 1024);
     if ($mb < 1024) {
-        return int($mb) . "MB";
+        return int($mb) . "MiB";
     }
     my $gb = $mb / 1024;
     if ($gb < 1024) {
-        return sprintf("%.2fGB", $gb);
+        return sprintf("%.2fGiB", $gb);
     }
     my $tb = $gb / 1024;
-    return sprintf("%.2fTB", $tb);
+    return sprintf("%.2fTiB", $tb);
 }
 
 sub format_time {
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-23 11:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 11:57 [pve-devel] [PATCH-SERIES common/manager/qemu-server v3 0/6] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB Fiona Ebner
2025-07-23 11:57 ` [pve-devel] [PATCH common v3 1/6] schema: support " Fiona Ebner
2025-07-29 15:48   ` [pve-devel] applied: " Thomas Lamprecht
2025-07-23 11:57 ` [pve-devel] [PATCH common v3 2/6] fix #3900: schema: prefer " Fiona Ebner
2025-07-23 11:57 ` Fiona Ebner [this message]
2025-07-23 11:57 ` [pve-devel] [PATCH manager v3 4/6] test: adapt tests to use verbose disk size suffixes Fiona Ebner
2025-07-23 11:57 ` [pve-devel] [PATCH qemu-server v3 5/6] test: fix tests for changes when printing disk size suffix Fiona Ebner
2025-07-23 11:57 ` [pve-devel] [PATCH qemu-server v3 6/6] test: adapt all tests to use verbose disk size suffixes Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250723115809.96282-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal