* [pbs-devel] [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible
@ 2025-07-23 11:50 Christian Ebner
2025-07-23 11:57 ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
0 siblings, 1 reply; 5+ messages in thread
From: Christian Ebner @ 2025-07-23 11:50 UTC (permalink / raw)
To: pbs-devel
Commit 90723828 ("api: backup: add no-cache flag to bypass local
datastore cache") introduced the additional flag to request bypassing
of the datastore cache by the Proxmox Backup Server.
The flag is however included in the backup api request parameters,
which is incompatible with older version of the server.
Fix this by only setting the flag if requested explicitley on
invocation, as it is then not included for requests to older servers
and for newer the default is to set this to false if not present
anyways.
Fixes: 90723828 ("api: backup: add no-cache flag to bypass local datastore cache")
Reported-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
pbs-client/src/backup_writer.rs | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs
index abe7c79e2..9f62baba3 100644
--- a/pbs-client/src/backup_writer.rs
+++ b/pbs-client/src/backup_writer.rs
@@ -102,8 +102,10 @@ impl BackupWriter {
"store": writer_options.datastore,
"debug": writer_options.debug,
"benchmark": writer_options.benchmark,
- "no-cache": writer_options.no_cache,
});
+ if writer_options.no_cache {
+ param["no-cache"] = serde_json::to_value(writer_options.no_cache)?;
+ }
if !writer_options.ns.is_root() {
param["ns"] = serde_json::to_value(writer_options.ns)?;
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* [pbs-devel] applied: [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible
2025-07-23 11:50 [pbs-devel] [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible Christian Ebner
@ 2025-07-23 11:57 ` Thomas Lamprecht
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2025-07-23 11:57 UTC (permalink / raw)
To: pve-devel, pbs-devel, Christian Ebner
On Wed, 23 Jul 2025 13:50:15 +0200, Christian Ebner wrote:
> Commit 90723828 ("api: backup: add no-cache flag to bypass local
> datastore cache") introduced the additional flag to request bypassing
> of the datastore cache by the Proxmox Backup Server.
>
> The flag is however included in the backup api request parameters,
> which is incompatible with older version of the server.
>
> [...]
Applied, thanks!
[1/1] client: backup writer: make no-cache parameter backwards compatible
commit: c763a0e9dff12acda8a84c70df08e637ba2a67bf
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* [pve-devel] applied: [pbs-devel] [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible
@ 2025-07-23 11:57 ` Thomas Lamprecht
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2025-07-23 11:57 UTC (permalink / raw)
To: pve-devel, pbs-devel, Christian Ebner
On Wed, 23 Jul 2025 13:50:15 +0200, Christian Ebner wrote:
> Commit 90723828 ("api: backup: add no-cache flag to bypass local
> datastore cache") introduced the additional flag to request bypassing
> of the datastore cache by the Proxmox Backup Server.
>
> The flag is however included in the backup api request parameters,
> which is incompatible with older version of the server.
>
> [...]
Applied, thanks!
[1/1] client: backup writer: make no-cache parameter backwards compatible
commit: c763a0e9dff12acda8a84c70df08e637ba2a67bf
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [pbs-devel] applied: [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible
2025-07-23 11:57 ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
@ 2025-07-23 12:08 ` Maximiliano Sandoval
-1 siblings, 0 replies; 5+ messages in thread
From: Maximiliano Sandoval @ 2025-07-23 12:08 UTC (permalink / raw)
To: Thomas Lamprecht; +Cc: pve-devel, pbs-devel
Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
> On Wed, 23 Jul 2025 13:50:15 +0200, Christian Ebner wrote:
>> Commit 90723828 ("api: backup: add no-cache flag to bypass local
>> datastore cache") introduced the additional flag to request bypassing
>> of the datastore cache by the Proxmox Backup Server.
>>
>> The flag is however included in the backup api request parameters,
>> which is incompatible with older version of the server.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] client: backup writer: make no-cache parameter backwards compatible
> commit: c763a0e9dff12acda8a84c70df08e637ba2a67bf
A bit late, but I can confirm this fixes encrypted backups of containers
(against a pbs server running 3.4.3) in pve for me.
--
Maximiliano
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [pve-devel] [pbs-devel] applied: [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible
@ 2025-07-23 12:08 ` Maximiliano Sandoval
0 siblings, 0 replies; 5+ messages in thread
From: Maximiliano Sandoval @ 2025-07-23 12:08 UTC (permalink / raw)
To: Thomas Lamprecht; +Cc: pve-devel, pbs-devel
Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
> On Wed, 23 Jul 2025 13:50:15 +0200, Christian Ebner wrote:
>> Commit 90723828 ("api: backup: add no-cache flag to bypass local
>> datastore cache") introduced the additional flag to request bypassing
>> of the datastore cache by the Proxmox Backup Server.
>>
>> The flag is however included in the backup api request parameters,
>> which is incompatible with older version of the server.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] client: backup writer: make no-cache parameter backwards compatible
> commit: c763a0e9dff12acda8a84c70df08e637ba2a67bf
A bit late, but I can confirm this fixes encrypted backups of containers
(against a pbs server running 3.4.3) in pve for me.
--
Maximiliano
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-23 12:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-23 11:50 [pbs-devel] [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible Christian Ebner
2025-07-23 11:57 ` [pbs-devel] applied: " Thomas Lamprecht
2025-07-23 11:57 ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2025-07-23 12:08 ` [pbs-devel] applied: " Maximiliano Sandoval
2025-07-23 12:08 ` [pve-devel] " Maximiliano Sandoval
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.