all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH FOLLOW-UP ha-manager 1/2] config: use entire path to groups.cfg path in delete_group_config
Date: Tue, 22 Jul 2025 18:54:27 +0200	[thread overview]
Message-ID: <20250722165428.90281-2-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20250722165428.90281-1-m.koeppl@proxmox.com>

Prepend /etc/pve/ to the path, as is done for other read and write
functions for the groups.cfg file. Otherwise, removing the file does not
work.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/PVE/HA/Config.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm
index 59bafd7..50d7972 100644
--- a/src/PVE/HA/Config.pm
+++ b/src/PVE/HA/Config.pm
@@ -235,8 +235,9 @@ sub read_group_config {
 }
 
 sub delete_group_config {
+    my $groups_config_file = "/etc/pve/$ha_groups_config";
 
-    unlink $ha_groups_config or die "failed to remove group config: $!\n";
+    unlink $groups_config_file or die "failed to remove group config: $!\n";
 }
 
 sub write_group_config {
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-07-22 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 16:54 [pve-devel] [PATCH FOLLOW-UP ha-manager 0/2] fix errors during persistent migration of HA groups to rules Michael Köppl
2025-07-22 16:54 ` Michael Köppl [this message]
2025-07-22 16:54 ` [pve-devel] [PATCH FOLLOW-UP ha-manager 2/2] ha: decode JSON string with version info returned by get_node_kv Michael Köppl
2025-07-23 15:37 ` [pve-devel] [PATCH FOLLOW-UP ha-manager 0/2] fix errors during persistent migration of HA groups to rules Michael Köppl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722165428.90281-2-m.koeppl@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal