* [pve-devel] [PATCH pve-storage v1] fix #6553: lvmthin: implement volume_rollback_is_possible sub
@ 2025-07-22 10:26 Max R. Carrara
2025-07-22 12:57 ` [pve-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 2+ messages in thread
From: Max R. Carrara @ 2025-07-22 10:26 UTC (permalink / raw)
To: pve-devel
Because LvmThinPlugin.pm uses LVMPlugin.pm as a base, it inherits the
`volume_rollback_is_possible()` subroutine added in eda88c94. Its
implementation however causes snapshot rollbacks to fail with
"can't rollback snapshot for 'raw' volume".
Fix this by implementing `volume_rollback_is_possible()`.
Closes: #6553
Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
src/PVE/Storage/LvmThinPlugin.pm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/Storage/LvmThinPlugin.pm b/src/PVE/Storage/LvmThinPlugin.pm
index 6f8a92e..ccefd0e 100644
--- a/src/PVE/Storage/LvmThinPlugin.pm
+++ b/src/PVE/Storage/LvmThinPlugin.pm
@@ -363,6 +363,12 @@ sub volume_snapshot {
# disabling autoactivation not needed, as -s defaults to --setautoactivationskip y
}
+sub volume_rollback_is_possible {
+ my ($class, $scfg, $storeid, $volname, $snap, $blockers) = @_;
+
+ return 1;
+}
+
sub volume_snapshot_rollback {
my ($class, $scfg, $storeid, $volname, $snap) = @_;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH pve-storage v1] fix #6553: lvmthin: implement volume_rollback_is_possible sub
2025-07-22 10:26 [pve-devel] [PATCH pve-storage v1] fix #6553: lvmthin: implement volume_rollback_is_possible sub Max R. Carrara
@ 2025-07-22 12:57 ` Wolfgang Bumiller
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2025-07-22 12:57 UTC (permalink / raw)
To: Max R. Carrara; +Cc: pve-devel
applied, thanks
On Tue, Jul 22, 2025 at 12:26:10PM +0200, Max R. Carrara wrote:
> Because LvmThinPlugin.pm uses LVMPlugin.pm as a base, it inherits the
> `volume_rollback_is_possible()` subroutine added in eda88c94. Its
> implementation however causes snapshot rollbacks to fail with
> "can't rollback snapshot for 'raw' volume".
>
> Fix this by implementing `volume_rollback_is_possible()`.
>
> Closes: #6553
> Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
> ---
> src/PVE/Storage/LvmThinPlugin.pm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/PVE/Storage/LvmThinPlugin.pm b/src/PVE/Storage/LvmThinPlugin.pm
> index 6f8a92e..ccefd0e 100644
> --- a/src/PVE/Storage/LvmThinPlugin.pm
> +++ b/src/PVE/Storage/LvmThinPlugin.pm
> @@ -363,6 +363,12 @@ sub volume_snapshot {
> # disabling autoactivation not needed, as -s defaults to --setautoactivationskip y
> }
>
> +sub volume_rollback_is_possible {
> + my ($class, $scfg, $storeid, $volname, $snap, $blockers) = @_;
> +
> + return 1;
> +}
> +
> sub volume_snapshot_rollback {
> my ($class, $scfg, $storeid, $volname, $snap) = @_;
>
> --
> 2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-22 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-22 10:26 [pve-devel] [PATCH pve-storage v1] fix #6553: lvmthin: implement volume_rollback_is_possible sub Max R. Carrara
2025-07-22 12:57 ` [pve-devel] applied: " Wolfgang Bumiller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.