all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 2/2] drive: get_drive_id: terminate error messages with newline
Date: Mon, 21 Jul 2025 14:38:21 +0200	[thread overview]
Message-ID: <20250721123829.85601-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250721123829.85601-1-f.ebner@proxmox.com>

To avoid Perl auto-attaching the line number and file.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer/Drive.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
index 50855ea8..9dc4e674 100644
--- a/src/PVE/QemuServer/Drive.pm
+++ b/src/PVE/QemuServer/Drive.pm
@@ -861,8 +861,8 @@ sub print_drive {
 sub get_drive_id {
     my ($drive) = @_;
 
-    die "get_drive_id: no interface" if !defined($drive->{interface});
-    die "get_drive_id: no index" if !defined($drive->{index});
+    die "get_drive_id: no interface\n" if !defined($drive->{interface});
+    die "get_drive_id: no index\n" if !defined($drive->{index});
 
     return "$drive->{interface}$drive->{index}";
 }
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-07-21 12:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-21 12:38 [pve-devel] [PATCH qemu-server 1/2] ovmf: use proper drive properties for temporary efi vars drive Fiona Ebner
2025-07-21 12:38 ` Fiona Ebner [this message]
2025-07-21 13:23 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250721123829.85601-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal