[pve-devel] [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by

[pve-devel] [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by

[Maximiliano Sandoval]

translator editors and will appear in po files as

```
#. TRANSLATORS: Stands for Complete Sequence Number Packet, see
#. https://datatracker.ietf.org/doc/html/draft-ietf-lsr-distoptflood#name-flooding-failures
#: pve-manager/www/manager6/sdn/fabrics/openfabric/FabricEdit.js:61
msgid "CSNP Interval"
msgstr "Intervalo de CSNP"
```

pve-manager:

Maximiliano Sandoval (1):
  add context to some translations

 www/manager6/grid/BackupView.js                   | 1 +
 www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++
 www/manager6/sdn/zones/VxlanEdit.js               | 1 +
 www/manager6/storage/BackupView.js                | 1 +
 www/manager6/storage/Base.js                      | 1 +
 www/manager6/window/Backup.js                     | 1 +
 6 files changed, 8 insertions(+)


proxmox-widget-toolkit:

Maximiliano Sandoval (1):
  add context to some translations

 src/form/MultiDiskSelector.js | 1 +
 1 file changed, 1 insertion(+)


pmg-gui:

Maximiliano Sandoval (1):
  add context to some translations

 js/MailProxyDKIMPanel.js | 2 ++
 js/Utils.js              | 2 ++
 2 files changed, 4 insertions(+)


proxmox-backup:

Maximiliano Sandoval (1):
  add context to some translations

 www/tape/DriveStatus.js     | 1 +
 www/window/DataStoreEdit.js | 1 +
 2 files changed, 2 insertions(+)


Summary over all repositories:
  11 files changed, 15 insertions(+), 0 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/1] add context to some translations

[Maximiliano Sandoval]

These will be displayed in translator editors and provide context for
translators.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/grid/BackupView.js                   | 1 +
 www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++
 www/manager6/sdn/zones/VxlanEdit.js               | 1 +
 www/manager6/storage/BackupView.js                | 1 +
 www/manager6/storage/Base.js                      | 1 +
 www/manager6/window/Backup.js                     | 1 +
 6 files changed, 8 insertions(+)

diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index d17c94b9..c1474e04 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -376,6 +376,7 @@ Ext.define('PVE.grid.BackupView', {
                     renderer: PVE.Utils.render_backup_encryption,
                 },
                 {
+		    // TRANSLATORS: The state of the verification task
                     header: gettext('Verify State'),
                     dataIndex: 'verification',
                     renderer: PVE.Utils.render_backup_verification,
diff --git a/www/manager6/sdn/fabrics/openfabric/FabricEdit.js b/www/manager6/sdn/fabrics/openfabric/FabricEdit.js
index 46dd61c4..14b71fae 100644
--- a/www/manager6/sdn/fabrics/openfabric/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/openfabric/FabricEdit.js
@@ -43,6 +43,7 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.Fabric.Edit', {
         },
         {
             xtype: 'proxmoxintegerfield',
+            // TRANSLATORS: See https://en.wikipedia.org/wiki/IS-IS#Packet_types
             fieldLabel: gettext('Hello Interval'),
             labelWidth: 120,
             name: 'hello_interval',
@@ -55,6 +56,8 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.Fabric.Edit', {
         },
         {
             xtype: 'proxmoxintegerfield',
+            // TRANSLATORS: Stands for Complete Sequence Number Packet, see
+            // https://datatracker.ietf.org/doc/html/draft-ietf-lsr-distoptflood#name-flooding-failures
             fieldLabel: gettext('CSNP Interval'),
             labelWidth: 120,
             name: 'csnp_interval',
diff --git a/www/manager6/sdn/zones/VxlanEdit.js b/www/manager6/sdn/zones/VxlanEdit.js
index 20e1c5bb..e45154a8 100644
--- a/www/manager6/sdn/zones/VxlanEdit.js
+++ b/www/manager6/sdn/zones/VxlanEdit.js
@@ -61,6 +61,7 @@ Ext.define('PVE.sdn.zones.VxlanInputPanel', {
                     width: 600,
                     columns: [
                         {
+                            // TRANSLATORS: As in "Network Fabric": https://en.wikipedia.org/wiki/Switched_fabric
                             header: gettext('Fabric'),
                             width: 90,
                             dataIndex: 'iface',
diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
index d2d1c0e6..f43c172d 100644
--- a/www/manager6/storage/BackupView.js
+++ b/www/manager6/storage/BackupView.js
@@ -213,6 +213,7 @@ Ext.define('PVE.storage.BackupView', {
                 },
             };
             me.extraColumns.verification = {
+		// TRANSLATORS: The state of the verification task
                 header: gettext('Verify State'),
                 dataIndex: 'verification',
                 renderer: PVE.Utils.render_backup_verification,
diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
index 98f004bd..d4b29f92 100644
--- a/www/manager6/storage/Base.js
+++ b/www/manager6/storage/Base.js
@@ -81,6 +81,7 @@ Ext.define('PVE.panel.StorageBase', {
             addAdvancedWidget({
                 xtype: 'proxmoxcheckbox',
                 name: 'snapshot-as-volume-chain',
+                // TRANSLATORS: As in "following the chain of volumes"
                 boxLabel: gettext('Allow Snapshots as Volume-Chain'),
                 deleteEmpty: !me.isCreate,
                 // can only allow to enable this on creation for storages that previously already
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 65ec9659..7c1c54de 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -41,6 +41,7 @@ Ext.define('PVE.window.Backup', {
             xtype: 'proxmoxKVComboBox',
             comboItems: [
                 ['notification-system', gettext('Use global settings')],
+                // TRANSLATORS: sendmail is a piece of software
                 ['legacy-sendmail', gettext('Use sendmail (legacy)')],
             ],
             fieldLabel: gettext('Notification'),
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH widget-toolkit 1/1] add context to some translations

[Maximiliano Sandoval]

These will be displayed in translator editors and provide context for
translators.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/form/MultiDiskSelector.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/form/MultiDiskSelector.js b/src/form/MultiDiskSelector.js
index 50e819b..51c3858 100644
--- a/src/form/MultiDiskSelector.js
+++ b/src/form/MultiDiskSelector.js
@@ -115,6 +115,7 @@ Ext.define('Proxmox.form.MultiDiskSelector', {
             flex: 1,
         },
         {
+            // TRANSLATORS: This is a noun
             header: gettext('Order'),
             xtype: 'widgetcolumn',
             dataIndex: 'order',
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pmg-gui 1/1] add context to some translations

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 js/MailProxyDKIMPanel.js | 2 ++
 js/Utils.js              | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/js/MailProxyDKIMPanel.js b/js/MailProxyDKIMPanel.js
index 022513a..3e388e8 100644
--- a/js/MailProxyDKIMPanel.js
+++ b/js/MailProxyDKIMPanel.js
@@ -3,6 +3,7 @@ Ext.define('PMG.DKIMDomains', {
     alias: ['widget.pmgDKIMDomains'],
 
     baseurl: '/config/dkim/domains',
+    // TRANSLATORS: As in "domain used to sign"
     domain_desc: gettext('Sign Domain'),
     onlineHelp: 'pmgconfig_mailproxy_dkim',
 });
@@ -31,6 +32,7 @@ Ext.define('PMG.MailProxyDKIMPanel', {
 	});
 
 	var DKIMDomains = Ext.create('PMG.DKIMDomains', {
+            // TRANSLATORS: As in "domains used to sign"
 	    title: gettext('Sign Domains'),
 	    flex: 1,
 	});
diff --git a/js/Utils.js b/js/Utils.js
index d563483..f9edc12 100644
--- a/js/Utils.js
+++ b/js/Utils.js
@@ -310,12 +310,14 @@ Ext.define('PMG.Utils', {
 		    xtype: 'timefield',
 		    name: 'start',
 		    format: 'H:i',
+                    // TRANSLATORS: As in "the time when the operation started"
 		    fieldLabel: gettext("Start Time"),
 		},
 		{
 		    xtype: 'timefield',
 		    name: 'end',
 		    format: 'H:i',
+                    // TRANSLATORS: As in "the time when the operation ended"
 		    fieldLabel: gettext("End Time"),
 		},
 	    ],
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH backup 1/1] add context to some translations

[Maximiliano Sandoval]

These will be displayed in translator editors and provide context for
translators.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/tape/DriveStatus.js     | 1 +
 www/window/DataStoreEdit.js | 1 +
 2 files changed, 2 insertions(+)

diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js
index 881bc1fdd..4405e4380 100644
--- a/www/tape/DriveStatus.js
+++ b/www/tape/DriveStatus.js
@@ -335,6 +335,7 @@ Ext.define('PBS.TapeManagement.DriveStatusGrid', {
                 if (!value) {
                     return gettext('Dynamic');
                 }
+                // TRANSLATORS: As in "fixed block size"
                 return `${gettext('Fixed')} - ${Proxmox.Utils.format_size(value)}`;
             },
         },
diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
index 372984e37..74deeade2 100644
--- a/www/window/DataStoreEdit.js
+++ b/www/window/DataStoreEdit.js
@@ -147,6 +147,7 @@ Ext.define('PBS.DataStoreEdit', {
                 },
             },
             {
+                // TRANSLATORS: As in "options of the prune operation"
                 title: gettext('Prune Options'),
                 xtype: 'pbsPruneInputPanel',
                 cbind: {
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by

[Shannon Sterz]

On Mon Jul 21, 2025 at 1:35 PM CEST, Maximiliano Sandoval wrote:
> translator editors and will appear in po files as
>
> ```
> #. TRANSLATORS: Stands for Complete Sequence Number Packet, see
> #. https://datatracker.ietf.org/doc/html/draft-ietf-lsr-distoptflood#name-flooding-failures
> #: pve-manager/www/manager6/sdn/fabrics/openfabric/FabricEdit.js:61
> msgid "CSNP Interval"
> msgstr "Intervalo de CSNP"
> ```
>
> pve-manager:
>
> Maximiliano Sandoval (1):
>   add context to some translations
>
>  www/manager6/grid/BackupView.js                   | 1 +
>  www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++
>  www/manager6/sdn/zones/VxlanEdit.js               | 1 +
>  www/manager6/storage/BackupView.js                | 1 +
>  www/manager6/storage/Base.js                      | 1 +
>  www/manager6/window/Backup.js                     | 1 +
>  6 files changed, 8 insertions(+)
>
>
> proxmox-widget-toolkit:
>
> Maximiliano Sandoval (1):
>   add context to some translations
>
>  src/form/MultiDiskSelector.js | 1 +
>  1 file changed, 1 insertion(+)
>
>
> pmg-gui:
>
> Maximiliano Sandoval (1):
>   add context to some translations
>
>  js/MailProxyDKIMPanel.js | 2 ++
>  js/Utils.js              | 2 ++
>  2 files changed, 4 insertions(+)
>
>
> proxmox-backup:
>
> Maximiliano Sandoval (1):
>   add context to some translations
>
>  www/tape/DriveStatus.js     | 1 +
>  www/window/DataStoreEdit.js | 1 +
>  2 files changed, 2 insertions(+)
>
>
> Summary over all repositories:
>   11 files changed, 15 insertions(+), 0 deletions(-)


This series looks good to me, i applied the patches and the strings show
up in the *.po files and, thus, poedit, after running make do_update (to
avoid possibly resetting the submodules again). So consider all four
patches:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Tested-by: Shannon Sterz <s.sterz@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] superseded: [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by

[Maximiliano Sandoval]

"Shannon Sterz" <s.sterz@proxmox.com> writes:

> On Mon Jul 21, 2025 at 1:35 PM CEST, Maximiliano Sandoval wrote:
>> translator editors and will appear in po files as
>>
>> ```
>> #. TRANSLATORS: Stands for Complete Sequence Number Packet, see
>> #. https://datatracker.ietf.org/doc/html/draft-ietf-lsr-distoptflood#name-flooding-failures
>> #: pve-manager/www/manager6/sdn/fabrics/openfabric/FabricEdit.js:61
>> msgid "CSNP Interval"
>> msgstr "Intervalo de CSNP"
>> ```
>>
>> pve-manager:
>>
>> Maximiliano Sandoval (1):
>>   add context to some translations
>>
>>  www/manager6/grid/BackupView.js                   | 1 +
>>  www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++
>>  www/manager6/sdn/zones/VxlanEdit.js               | 1 +
>>  www/manager6/storage/BackupView.js                | 1 +
>>  www/manager6/storage/Base.js                      | 1 +
>>  www/manager6/window/Backup.js                     | 1 +
>>  6 files changed, 8 insertions(+)
>>
>>
>> proxmox-widget-toolkit:
>>
>> Maximiliano Sandoval (1):
>>   add context to some translations
>>
>>  src/form/MultiDiskSelector.js | 1 +
>>  1 file changed, 1 insertion(+)
>>
>>
>> pmg-gui:
>>
>> Maximiliano Sandoval (1):
>>   add context to some translations
>>
>>  js/MailProxyDKIMPanel.js | 2 ++
>>  js/Utils.js              | 2 ++
>>  2 files changed, 4 insertions(+)
>>
>>
>> proxmox-backup:
>>
>> Maximiliano Sandoval (1):
>>   add context to some translations
>>
>>  www/tape/DriveStatus.js     | 1 +
>>  www/window/DataStoreEdit.js | 1 +
>>  2 files changed, 2 insertions(+)
>>
>>
>> Summary over all repositories:
>>   11 files changed, 15 insertions(+), 0 deletions(-)
>
>
> This series looks good to me, i applied the patches and the strings show
> up in the *.po files and, thus, poedit, after running make do_update (to
> avoid possibly resetting the submodules again). So consider all four
> patches:
>
> Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
> Tested-by: Shannon Sterz <s.sterz@proxmox.com>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Superseded by https://lore.proxmox.com/pve-devel/20250730103825.233570-1-m.sandoval@proxmox.com/T/#t.
-- 
Maximiliano


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel