all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] d/control: add python3-pyvmomi (>= 8) as build dependency
Date: Fri, 18 Jul 2025 18:19:04 +0200	[thread overview]
Message-ID: <20250718161905.461482-5-m.carrara@proxmox.com> (raw)
In-Reply-To: <20250718161905.461482-1-m.carrara@proxmox.com>

... and don't ignore missing imports for pyVmomi in mypy.ini anymore.

python3-pyvmomi >= 8 is available only on trixie, which includes a
bunch of new type stubs that were previously missing. This means that
mypy no longer has to ignore missing imports in regards to pyVmomi.

mypy will therefore now complain when it can't find pyVmomi, so any
strange behavior regarding type checking of pyVmomi's types should
hopefully not happen anymore.

Note that pyVim is part of python3-pyvmomi, but still doesn't provide
any proper type stubs / hints that mypy can use, so we keep it ignored
until it does.

Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
 debian/control | 1 +
 mypy.ini       | 3 ---
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index ee74e15..d57b302 100644
--- a/debian/control
+++ b/debian/control
@@ -38,6 +38,7 @@ Build-Depends: cargo:native (>= 0.65.0~),
                librust-tokio-1+time-dev,
                libstd-rust-dev,
                mypy,
+               python3-pyvmomi (>= 8),
                rustc:native,
 Maintainer: Proxmox Support Team <support@proxmox.com>
 Standards-Version: 4.6.2
diff --git a/mypy.ini b/mypy.ini
index e6724c8..0387e66 100644
--- a/mypy.ini
+++ b/mypy.ini
@@ -1,8 +1,5 @@
 [mypy]
 
-[mypy-pyVmomi]
-ignore_missing_imports = True
-
 [mypy-pyVim.*]
 ignore_missing_imports = True
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-18 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 16:19 [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Type Checking Improvements Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 1/5] listvms: respect new type hints of pyVmomi package Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 2/5] listvms: s/EsxiConnectonArgs/EsxiConnectionArgs Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 3/5] listvms: run formatter Max R. Carrara
2025-07-18 16:19 ` Max R. Carrara [this message]
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 5/5] .gitignore: ignore .lint-incremental Max R. Carrara
2025-07-22 20:14 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Type Checking Improvements Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250718161905.461482-5-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal