all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v1 pve-esxi-import-tools 3/5] listvms: run formatter
Date: Fri, 18 Jul 2025 18:19:03 +0200	[thread overview]
Message-ID: <20250718161905.461482-4-m.carrara@proxmox.com> (raw)
In-Reply-To: <20250718161905.461482-1-m.carrara@proxmox.com>

Like in 1563eddb, run `black -l 80` [0], even though we don't have an
official style guide for Python. This is just to keep the code looking
consistent.

[0]: https://github.com/psf/black

Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
 listvms.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/listvms.py b/listvms.py
index 710ac5e..a718c41 100755
--- a/listvms.py
+++ b/listvms.py
@@ -31,9 +31,9 @@ def parse_args() -> argparse.Namespace:
     parser.add_argument(
         "--port",
         type=int,
-        metavar='PORT',
+        metavar="PORT",
         default=443,
-        help="Use a port other than 443."
+        help="Use a port other than 443.",
     )
 
     parser.add_argument(
@@ -320,9 +320,11 @@ def is_vcls_agent_vm(vm: vim.VirtualMachine) -> bool:
     if vm.config is None:
         return False
 
-    return any(cfg.key == "HDCS.agent"
-               and cfg.value.lower() == "true"
-               for cfg in vm.config.extraConfig)
+    return any(
+        cfg.key == "HDCS.agent" and cfg.value.lower() == "true"
+        for cfg in vm.config.extraConfig
+    )
+
 
 def is_diskless_vm(vm: vim.VirtualMachine) -> bool:
     if vm.config is None or vm.config.files is None:
@@ -332,6 +334,7 @@ def is_diskless_vm(vm: vim.VirtualMachine) -> bool:
 
     return not datastore_name
 
+
 def main():
     args = parse_args()
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-18 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 16:19 [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Type Checking Improvements Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 1/5] listvms: respect new type hints of pyVmomi package Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 2/5] listvms: s/EsxiConnectonArgs/EsxiConnectionArgs Max R. Carrara
2025-07-18 16:19 ` Max R. Carrara [this message]
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] d/control: add python3-pyvmomi (>= 8) as build dependency Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 5/5] .gitignore: ignore .lint-incremental Max R. Carrara
2025-07-22 20:14 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Type Checking Improvements Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250718161905.461482-4-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal